Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Side by Side Diff: src/heap/heap.cc

Issue 2236443004: [turbofan] Introduce a dedicated ConvertTaggedHoleToUndefined operator. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Introduce appropriate Type::Hole Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/verifier.cc ('k') | src/types.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/heap/heap.h" 5 #include "src/heap/heap.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api.h" 8 #include "src/api.h"
9 #include "src/ast/context-slot-cache.h" 9 #include "src/ast/context-slot-cache.h"
10 #include "src/base/bits.h" 10 #include "src/base/bits.h"
(...skipping 2611 matching lines...) Expand 10 before | Expand all | Expand 10 after
2622 Oddball::Initialize(isolate(), factory->undefined_value(), "undefined", 2622 Oddball::Initialize(isolate(), factory->undefined_value(), "undefined",
2623 factory->nan_value(), "undefined", Oddball::kUndefined); 2623 factory->nan_value(), "undefined", Oddball::kUndefined);
2624 2624
2625 // Initialize the null_value. 2625 // Initialize the null_value.
2626 Oddball::Initialize(isolate(), factory->null_value(), "null", 2626 Oddball::Initialize(isolate(), factory->null_value(), "null",
2627 handle(Smi::FromInt(0), isolate()), "object", 2627 handle(Smi::FromInt(0), isolate()), "object",
2628 Oddball::kNull); 2628 Oddball::kNull);
2629 2629
2630 // Initialize the_hole_value. 2630 // Initialize the_hole_value.
2631 Oddball::Initialize(isolate(), factory->the_hole_value(), "hole", 2631 Oddball::Initialize(isolate(), factory->the_hole_value(), "hole",
2632 handle(Smi::FromInt(-1), isolate()), "undefined", 2632 factory->NewHeapNumber(bit_cast<double>(kHoleNanInt64)),
Michael Starzinger 2016/08/10 13:59:37 nit: Please pretenure this heap-number to avoid ol
Benedikt Meurer 2016/08/10 14:01:00 Done.
2633 Oddball::kTheHole); 2633 "undefined", Oddball::kTheHole);
2634 2634
2635 // Initialize the true_value. 2635 // Initialize the true_value.
2636 Oddball::Initialize(isolate(), factory->true_value(), "true", 2636 Oddball::Initialize(isolate(), factory->true_value(), "true",
2637 handle(Smi::FromInt(1), isolate()), "boolean", 2637 handle(Smi::FromInt(1), isolate()), "boolean",
2638 Oddball::kTrue); 2638 Oddball::kTrue);
2639 2639
2640 // Initialize the false_value. 2640 // Initialize the false_value.
2641 Oddball::Initialize(isolate(), factory->false_value(), "false", 2641 Oddball::Initialize(isolate(), factory->false_value(), "false",
2642 handle(Smi::FromInt(0), isolate()), "boolean", 2642 handle(Smi::FromInt(0), isolate()), "boolean",
2643 Oddball::kFalse); 2643 Oddball::kFalse);
(...skipping 3839 matching lines...) Expand 10 before | Expand all | Expand 10 after
6483 } 6483 }
6484 6484
6485 6485
6486 // static 6486 // static
6487 int Heap::GetStaticVisitorIdForMap(Map* map) { 6487 int Heap::GetStaticVisitorIdForMap(Map* map) {
6488 return StaticVisitorBase::GetVisitorId(map); 6488 return StaticVisitorBase::GetVisitorId(map);
6489 } 6489 }
6490 6490
6491 } // namespace internal 6491 } // namespace internal
6492 } // namespace v8 6492 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/verifier.cc ('k') | src/types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698