Deoptimization is easier to diagnose when there is a text reason.

Deoptimization is easier to diagnose when there is a text reason.

BUG=
R=verwaest@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=16131

[mvstanton, 2013-08-09 12:35:16]

Hi Toon, here is the change we discussed for deopt reasons.
Thanks,
--Michael

[Toon Verwaest, 2013-08-09 12:41:28]

lgtm with 2 nits.

https://codereview.chromium.org/22339018/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/22339018/diff/1/src/hydrogen.cc#newcode1111
src/hydrogen.cc:1111: key_checker.ElseDeopt("key out of capacity range");
Uppercase k

https://codereview.chromium.org/22339018/diff/1/src/hydrogen.cc#newcode5596
src/hydrogen.cc:5596: FinishExitWithHardDeoptimization(join,
Can we make the reason here also the first argument, just like for all other
methods that get the reason as input?

[mvstanton, 2013-08-09 12:49:11]

Thanks, comments addressed, much appreciated.
--Michael

https://codereview.chromium.org/22339018/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/22339018/diff/1/src/hydrogen.cc#newcode1111
src/hydrogen.cc:1111: key_checker.ElseDeopt("key out of capacity range");
On 2013/08/09 12:41:28, Toon Verwaest wrote:
> Uppercase k

Done.

https://codereview.chromium.org/22339018/diff/1/src/hydrogen.cc#newcode5596
src/hydrogen.cc:5596: FinishExitWithHardDeoptimization(join,
On 2013/08/09 12:41:28, Toon Verwaest wrote:
> Can we make the reason here also the first argument, just like for all other
> methods that get the reason as input?

Done.

[mvstanton, 2013-08-09 12:50:49]

Committed patchset #2 manually as r16131 (presubmit successful).