Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: src/mips/lithium-codegen-mips.cc

Issue 22339018: Deoptimization is easier to diagnose when there is a text reason. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5657 matching lines...) Expand 10 before | Expand all | Expand 10 after
5668 5668
5669 void LCodeGen::DoDeoptimize(LDeoptimize* instr) { 5669 void LCodeGen::DoDeoptimize(LDeoptimize* instr) {
5670 Deoptimizer::BailoutType type = instr->hydrogen()->type(); 5670 Deoptimizer::BailoutType type = instr->hydrogen()->type();
5671 // TODO(danno): Stubs expect all deopts to be lazy for historical reasons (the 5671 // TODO(danno): Stubs expect all deopts to be lazy for historical reasons (the
5672 // needed return address), even though the implementation of LAZY and EAGER is 5672 // needed return address), even though the implementation of LAZY and EAGER is
5673 // now identical. When LAZY is eventually completely folded into EAGER, remove 5673 // now identical. When LAZY is eventually completely folded into EAGER, remove
5674 // the special case below. 5674 // the special case below.
5675 if (info()->IsStub() && type == Deoptimizer::EAGER) { 5675 if (info()->IsStub() && type == Deoptimizer::EAGER) {
5676 type = Deoptimizer::LAZY; 5676 type = Deoptimizer::LAZY;
5677 } 5677 }
5678
5679 Comment(";;; deoptimize: %s", instr->hydrogen()->reason());
5678 DeoptimizeIf(al, instr->environment(), type, zero_reg, Operand(zero_reg)); 5680 DeoptimizeIf(al, instr->environment(), type, zero_reg, Operand(zero_reg));
5679 } 5681 }
5680 5682
5681 5683
5682 void LCodeGen::DoDummyUse(LDummyUse* instr) { 5684 void LCodeGen::DoDummyUse(LDummyUse* instr) {
5683 // Nothing to see here, move on! 5685 // Nothing to see here, move on!
5684 } 5686 }
5685 5687
5686 5688
5687 void LCodeGen::DoDeferredStackCheck(LStackCheck* instr) { 5689 void LCodeGen::DoDeferredStackCheck(LStackCheck* instr) {
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
5846 __ Subu(scratch, result, scratch); 5848 __ Subu(scratch, result, scratch);
5847 __ lw(result, FieldMemOperand(scratch, 5849 __ lw(result, FieldMemOperand(scratch,
5848 FixedArray::kHeaderSize - kPointerSize)); 5850 FixedArray::kHeaderSize - kPointerSize));
5849 __ bind(&done); 5851 __ bind(&done);
5850 } 5852 }
5851 5853
5852 5854
5853 #undef __ 5855 #undef __
5854 5856
5855 } } // namespace v8::internal 5857 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698