Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 22339018: Deoptimization is easier to diagnose when there is a text reason. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 6358 matching lines...) Expand 10 before | Expand all | Expand 10 after
6369 6369
6370 void LCodeGen::DoDeoptimize(LDeoptimize* instr) { 6370 void LCodeGen::DoDeoptimize(LDeoptimize* instr) {
6371 Deoptimizer::BailoutType type = instr->hydrogen()->type(); 6371 Deoptimizer::BailoutType type = instr->hydrogen()->type();
6372 // TODO(danno): Stubs expect all deopts to be lazy for historical reasons (the 6372 // TODO(danno): Stubs expect all deopts to be lazy for historical reasons (the
6373 // needed return address), even though the implementation of LAZY and EAGER is 6373 // needed return address), even though the implementation of LAZY and EAGER is
6374 // now identical. When LAZY is eventually completely folded into EAGER, remove 6374 // now identical. When LAZY is eventually completely folded into EAGER, remove
6375 // the special case below. 6375 // the special case below.
6376 if (info()->IsStub() && type == Deoptimizer::EAGER) { 6376 if (info()->IsStub() && type == Deoptimizer::EAGER) {
6377 type = Deoptimizer::LAZY; 6377 type = Deoptimizer::LAZY;
6378 } 6378 }
6379 Comment(";;; deoptimize: %s", instr->hydrogen()->reason());
6379 DeoptimizeIf(no_condition, instr->environment(), type); 6380 DeoptimizeIf(no_condition, instr->environment(), type);
6380 } 6381 }
6381 6382
6382 6383
6383 void LCodeGen::DoDummyUse(LDummyUse* instr) { 6384 void LCodeGen::DoDummyUse(LDummyUse* instr) {
6384 // Nothing to see here, move on! 6385 // Nothing to see here, move on!
6385 } 6386 }
6386 6387
6387 6388
6388 void LCodeGen::DoDeferredStackCheck(LStackCheck* instr) { 6389 void LCodeGen::DoDeferredStackCheck(LStackCheck* instr) {
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
6550 FixedArray::kHeaderSize - kPointerSize)); 6551 FixedArray::kHeaderSize - kPointerSize));
6551 __ bind(&done); 6552 __ bind(&done);
6552 } 6553 }
6553 6554
6554 6555
6555 #undef __ 6556 #undef __
6556 6557
6557 } } // namespace v8::internal 6558 } } // namespace v8::internal
6558 6559
6559 #endif // V8_TARGET_ARCH_IA32 6560 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.h ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698