Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/x64/lithium-codegen-x64.cc

Issue 22339018: Deoptimization is easier to diagnose when there is a text reason. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/lithium-codegen-mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5429 matching lines...) Expand 10 before | Expand all | Expand 10 after
5440 5440
5441 void LCodeGen::DoDeoptimize(LDeoptimize* instr) { 5441 void LCodeGen::DoDeoptimize(LDeoptimize* instr) {
5442 Deoptimizer::BailoutType type = instr->hydrogen()->type(); 5442 Deoptimizer::BailoutType type = instr->hydrogen()->type();
5443 // TODO(danno): Stubs expect all deopts to be lazy for historical reasons (the 5443 // TODO(danno): Stubs expect all deopts to be lazy for historical reasons (the
5444 // needed return address), even though the implementation of LAZY and EAGER is 5444 // needed return address), even though the implementation of LAZY and EAGER is
5445 // now identical. When LAZY is eventually completely folded into EAGER, remove 5445 // now identical. When LAZY is eventually completely folded into EAGER, remove
5446 // the special case below. 5446 // the special case below.
5447 if (info()->IsStub() && type == Deoptimizer::EAGER) { 5447 if (info()->IsStub() && type == Deoptimizer::EAGER) {
5448 type = Deoptimizer::LAZY; 5448 type = Deoptimizer::LAZY;
5449 } 5449 }
5450
5451 Comment(";;; deoptimize: %s", instr->hydrogen()->reason());
5450 DeoptimizeIf(no_condition, instr->environment(), type); 5452 DeoptimizeIf(no_condition, instr->environment(), type);
5451 } 5453 }
5452 5454
5453 5455
5454 void LCodeGen::DoDummyUse(LDummyUse* instr) { 5456 void LCodeGen::DoDummyUse(LDummyUse* instr) {
5455 // Nothing to see here, move on! 5457 // Nothing to see here, move on!
5456 } 5458 }
5457 5459
5458 5460
5459 void LCodeGen::DoDeferredStackCheck(LStackCheck* instr) { 5461 void LCodeGen::DoDeferredStackCheck(LStackCheck* instr) {
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
5617 FixedArray::kHeaderSize - kPointerSize)); 5619 FixedArray::kHeaderSize - kPointerSize));
5618 __ bind(&done); 5620 __ bind(&done);
5619 } 5621 }
5620 5622
5621 5623
5622 #undef __ 5624 #undef __
5623 5625
5624 } } // namespace v8::internal 5626 } } // namespace v8::internal
5625 5627
5626 #endif // V8_TARGET_ARCH_X64 5628 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/mips/lithium-codegen-mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698