Make Variable::is_this always return the correct value

Make Variable::is_this always return the correct value

BUG=

Committed: https://crrev.com/923c45198abf076630b395270cd1856949b7a5eb
Cr-Commit-Position: refs/heads/master@{#38599}

[Toon Verwaest, 2016-08-10 16:50:03]

verwaest@chromium.org changed reviewers:
+ adamk@chromium.org, mstarzinger@chromium.org, rmcilroy@chromium.org

[Toon Verwaest, 2016-08-10 16:50:03]

ptal. Whoever has great insight, please review in-depth... Seems like there were
many hacks around bugs involved.

[Toon Verwaest, 2016-08-10 16:57:59]

The CQ bit was checked by verwaest@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 16:58:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-10 17:25:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 17:25:16]

Dry run: This issue passed the CQ dry run.

[adamk, 2016-08-10 17:57:40]

Getting rid of Variable::HasThisName() is a noble pursuit, I just don't think we
want to further mix together VariableProxy and Variable::Kind.

https://codereview.chromium.org/2231813003/diff/40001/src/ast/ast.h
File src/ast/ast.h (right):

https://codereview.chromium.org/2231813003/diff/40001/src/ast/ast.h#newcode1636
src/ast/ast.h:1636: return is_this() ? Variable::THIS : Variable::NORMAL;
I think the reason this bugs me is that var_kind() and var()->kind() can
disagree.

https://codereview.chromium.org/2231813003/diff/40001/src/ast/scopes.cc
File src/ast/scopes.cc (right):

https://codereview.chromium.org/2231813003/diff/40001/src/ast/scopes.cc#newco...
src/ast/scopes.cc:1365: void Scope::ResolveTo(ParseInfo* info, BindingKind
binding_kind,
It looks like this is the only code that calls VariableProxy::var_kind(). Could
you just do the switching logic here instead?

[Michael Starzinger, 2016-08-10 19:45:13]

Changes to the back-ends LGTM. I didn't look at the changes to the variable
resolution at all and leave reviewing that to Adam.

https://codereview.chromium.org/2231813003/diff/40001/src/compiler/ast-graph-...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/2231813003/diff/40001/src/compiler/ast-graph-...
src/compiler/ast-graph-builder.cc:2942: // Delete of an unqualified identifier
is disallowed in strict mode but
nit: I know this is not your code, but while you are here, could you drop one of
those two comments that say the same thing twice. Thanks! :)

[rmcilroy, 2016-08-10 20:25:42]

Overall looks good from my point of view. Thanks for getting rid of HasThisName!

[Toon Verwaest, 2016-08-11 08:46:25]

Addressed comments

https://codereview.chromium.org/2231813003/diff/40001/src/ast/ast.h
File src/ast/ast.h (right):

https://codereview.chromium.org/2231813003/diff/40001/src/ast/ast.h#newcode1636
src/ast/ast.h:1636: return is_this() ? Variable::THIS : Variable::NORMAL;
On 2016/08/10 17:57:39, adamk wrote:
> I think the reason this bugs me is that var_kind() and var()->kind() can
> disagree.

Acknowledged.

https://codereview.chromium.org/2231813003/diff/40001/src/ast/scopes.cc
File src/ast/scopes.cc (right):

https://codereview.chromium.org/2231813003/diff/40001/src/ast/scopes.cc#newco...
src/ast/scopes.cc:1365: void Scope::ResolveTo(ParseInfo* info, BindingKind
binding_kind,
On 2016/08/10 17:57:39, adamk wrote:
> It looks like this is the only code that calls VariableProxy::var_kind().
Could
> you just do the switching logic here instead?

Done.

https://codereview.chromium.org/2231813003/diff/40001/src/compiler/ast-graph-...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/2231813003/diff/40001/src/compiler/ast-graph-...
src/compiler/ast-graph-builder.cc:2942: // Delete of an unqualified identifier
is disallowed in strict mode but
On 2016/08/10 19:45:13, Michael Starzinger wrote:
> nit: I know this is not your code, but while you are here, could you drop one
of
> those two comments that say the same thing twice. Thanks! :)

Done.

[rmcilroy, 2016-08-11 09:53:18]

LGTM

[adamk, 2016-08-11 16:45:42]

lgtm

[Toon Verwaest, 2016-08-11 17:10:21]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-08-11 17:10:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2231813003/#ps60001
(title: "Addressed comments")

[commit-bot: I haz the power, 2016-08-11 17:10:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 17:13:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 17:13:53]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/21656)

[Toon Verwaest, 2016-08-11 17:23:09]

verwaest@chromium.org changed reviewers:
+ ahaas@chromium.org

[Toon Verwaest, 2016-08-11 17:23:09]

@ahaas:ptal

[ahaas, 2016-08-11 17:48:23]

On 2016/08/11 at 17:23:09, verwaest wrote:
> @ahaas:ptal

asmjs lgtm

[ahaas, 2016-08-11 17:48:35]

The CQ bit was checked by ahaas@chromium.org

[commit-bot: I haz the power, 2016-08-11 17:48:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 17:51:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 17:51:11]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/21665)

[Toon Verwaest, 2016-08-12 07:46:54]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-08-12 07:46:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, adamk@chromium.org, ahaas@chromium.org,
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2231813003/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-12 07:47:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 08:15:28]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-12 08:15:44]

Description was changed from

==========
Make Variable::is_this always return the correct value

BUG=
==========

to

==========
Make Variable::is_this always return the correct value

BUG=

Committed: https://crrev.com/923c45198abf076630b395270cd1856949b7a5eb
Cr-Commit-Position: refs/heads/master@{#38599}
==========

[commit-bot: I haz the power, 2016-08-12 08:15:45]

Patchset 5 (id:??) landed as
https://crrev.com/923c45198abf076630b395270cd1856949b7a5eb
Cr-Commit-Position: refs/heads/master@{#38599}