Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: src/ast/variables.h

Issue 2231813003: Make Variable::is_this always return the correct value (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/scopes.cc ('k') | src/ast/variables.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/variables.h
diff --git a/src/ast/variables.h b/src/ast/variables.h
index 9dae9e634abdf59d2123893b52d20919aa96e91f..57448245290d5bc9474b52a581af87c97f445192 100644
--- a/src/ast/variables.h
+++ b/src/ast/variables.h
@@ -82,22 +82,6 @@ class Variable: public ZoneObject {
bool is_this() const { return kind_ == THIS; }
bool is_arguments() const { return kind_ == ARGUMENTS; }
- // For script scopes, the "this" binding is provided by a ScriptContext added
- // to the global's ScriptContextTable. This binding might not statically
- // resolve to a Variable::THIS binding, instead being DYNAMIC_LOCAL. However
- // any variable named "this" does indeed refer to a Variable::THIS binding;
- // the grammar ensures this to be the case. So wherever a "this" binding
- // might be provided by the global, use HasThisName instead of is_this().
- bool HasThisName(Isolate* isolate,
- HandleDereferenceMode deref_mode =
- HandleDereferenceMode::kAllowed) const {
- // Note: it is safe to dereference isolate->factory()->this_string() here
- // regardless of |deref_mode| because it is a constant root and so will
- // never be updated or moved.
- return is_this() ||
- name_is_identical_to(isolate->factory()->this_string(), deref_mode);
- }
-
// True if the variable is named eval and not known to be shadowed.
bool is_possibly_eval(Isolate* isolate,
HandleDereferenceMode deref_mode =
« no previous file with comments | « src/ast/scopes.cc ('k') | src/ast/variables.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698