Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Side by Side Diff: src/full-codegen/mips/full-codegen-mips.cc

Issue 2231813003: Make Variable::is_this always return the correct value (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 3052 matching lines...) Expand 10 before | Expand all | Expand 10 after
3063 VisitForStackValue(property->obj()); 3063 VisitForStackValue(property->obj());
3064 VisitForStackValue(property->key()); 3064 VisitForStackValue(property->key());
3065 CallRuntimeWithOperands(is_strict(language_mode()) 3065 CallRuntimeWithOperands(is_strict(language_mode())
3066 ? Runtime::kDeleteProperty_Strict 3066 ? Runtime::kDeleteProperty_Strict
3067 : Runtime::kDeleteProperty_Sloppy); 3067 : Runtime::kDeleteProperty_Sloppy);
3068 context()->Plug(v0); 3068 context()->Plug(v0);
3069 } else if (proxy != NULL) { 3069 } else if (proxy != NULL) {
3070 Variable* var = proxy->var(); 3070 Variable* var = proxy->var();
3071 // Delete of an unqualified identifier is disallowed in strict mode but 3071 // Delete of an unqualified identifier is disallowed in strict mode but
3072 // "delete this" is allowed. 3072 // "delete this" is allowed.
3073 bool is_this = var->HasThisName(isolate()); 3073 bool is_this = var->is_this();
3074 DCHECK(is_sloppy(language_mode()) || is_this); 3074 DCHECK(is_sloppy(language_mode()) || is_this);
3075 if (var->IsUnallocatedOrGlobalSlot()) { 3075 if (var->IsUnallocatedOrGlobalSlot()) {
3076 __ LoadGlobalObject(a2); 3076 __ LoadGlobalObject(a2);
3077 __ li(a1, Operand(var->name())); 3077 __ li(a1, Operand(var->name()));
3078 __ Push(a2, a1); 3078 __ Push(a2, a1);
3079 __ CallRuntime(Runtime::kDeleteProperty_Sloppy); 3079 __ CallRuntime(Runtime::kDeleteProperty_Sloppy);
3080 context()->Plug(v0); 3080 context()->Plug(v0);
3081 } else if (var->IsStackAllocated() || var->IsContextSlot()) { 3081 } else if (var->IsStackAllocated() || var->IsContextSlot()) {
3082 // Result of deleting non-global, non-dynamic variables is false. 3082 // Result of deleting non-global, non-dynamic variables is false.
3083 // The subexpression does not have side effects. 3083 // The subexpression does not have side effects.
(...skipping 695 matching lines...) Expand 10 before | Expand all | Expand 10 after
3779 reinterpret_cast<uint32_t>( 3779 reinterpret_cast<uint32_t>(
3780 isolate->builtins()->OnStackReplacement()->entry())); 3780 isolate->builtins()->OnStackReplacement()->entry()));
3781 return ON_STACK_REPLACEMENT; 3781 return ON_STACK_REPLACEMENT;
3782 } 3782 }
3783 3783
3784 3784
3785 } // namespace internal 3785 } // namespace internal
3786 } // namespace v8 3786 } // namespace v8
3787 3787
3788 #endif // V8_TARGET_ARCH_MIPS 3788 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/full-codegen/ia32/full-codegen-ia32.cc ('k') | src/full-codegen/mips64/full-codegen-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698