Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Side by Side Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 2231813003: Make Variable::is_this always return the correct value (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/ast/scopes.h" 7 #include "src/ast/scopes.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/codegen.h" 10 #include "src/codegen.h"
(...skipping 3045 matching lines...) Expand 10 before | Expand all | Expand 10 after
3056 VisitForStackValue(property->obj()); 3056 VisitForStackValue(property->obj());
3057 VisitForStackValue(property->key()); 3057 VisitForStackValue(property->key());
3058 CallRuntimeWithOperands(is_strict(language_mode()) 3058 CallRuntimeWithOperands(is_strict(language_mode())
3059 ? Runtime::kDeleteProperty_Strict 3059 ? Runtime::kDeleteProperty_Strict
3060 : Runtime::kDeleteProperty_Sloppy); 3060 : Runtime::kDeleteProperty_Sloppy);
3061 context()->Plug(r0); 3061 context()->Plug(r0);
3062 } else if (proxy != NULL) { 3062 } else if (proxy != NULL) {
3063 Variable* var = proxy->var(); 3063 Variable* var = proxy->var();
3064 // Delete of an unqualified identifier is disallowed in strict mode but 3064 // Delete of an unqualified identifier is disallowed in strict mode but
3065 // "delete this" is allowed. 3065 // "delete this" is allowed.
3066 bool is_this = var->HasThisName(isolate()); 3066 bool is_this = var->is_this();
3067 DCHECK(is_sloppy(language_mode()) || is_this); 3067 DCHECK(is_sloppy(language_mode()) || is_this);
3068 if (var->IsUnallocatedOrGlobalSlot()) { 3068 if (var->IsUnallocatedOrGlobalSlot()) {
3069 __ LoadGlobalObject(r2); 3069 __ LoadGlobalObject(r2);
3070 __ mov(r1, Operand(var->name())); 3070 __ mov(r1, Operand(var->name()));
3071 __ Push(r2, r1); 3071 __ Push(r2, r1);
3072 __ CallRuntime(Runtime::kDeleteProperty_Sloppy); 3072 __ CallRuntime(Runtime::kDeleteProperty_Sloppy);
3073 context()->Plug(r0); 3073 context()->Plug(r0);
3074 } else if (var->IsStackAllocated() || var->IsContextSlot()) { 3074 } else if (var->IsStackAllocated() || var->IsContextSlot()) {
3075 // Result of deleting non-global, non-dynamic variables is false. 3075 // Result of deleting non-global, non-dynamic variables is false.
3076 // The subexpression does not have side effects. 3076 // The subexpression does not have side effects.
(...skipping 762 matching lines...) Expand 10 before | Expand all | Expand 10 after
3839 DCHECK(interrupt_address == 3839 DCHECK(interrupt_address ==
3840 isolate->builtins()->OnStackReplacement()->entry()); 3840 isolate->builtins()->OnStackReplacement()->entry());
3841 return ON_STACK_REPLACEMENT; 3841 return ON_STACK_REPLACEMENT;
3842 } 3842 }
3843 3843
3844 3844
3845 } // namespace internal 3845 } // namespace internal
3846 } // namespace v8 3846 } // namespace v8
3847 3847
3848 #endif // V8_TARGET_ARCH_ARM 3848 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/full-codegen/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698