Remove unnecessary |show_on_tap_for_empty_editable| flag

Remove unnecessary |show_on_tap_for_empty_editable| flag

This flag used to used by aura but is now only set to false. This
change removes the flag.

BUG=636481
Committed: https://crrev.com/add0668da5a805a55086676b0933da685574a0f3
Cr-Commit-Position: refs/heads/master@{#412024}

[amaralp, 2016-08-10 18:01:49]

The CQ bit was checked by amaralp@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-10 18:03:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[amaralp, 2016-08-10 18:41:09]

Description was changed from

==========
Remove unnecessary |show_on_tap_for_empty_editable| flag

BUG=
==========

to

==========
Remove unnecessary |show_on_tap_for_empty_editable| flag

This flag used to used by aura but is now only set to false. This
change removes the flag.

BUG=
==========

[amaralp, 2016-08-10 18:41:09]

amaralp@chromium.org changed reviewers:
+ aelias@chromium.org

[amaralp, 2016-08-10 18:45:01]

Description was changed from

==========
Remove unnecessary |show_on_tap_for_empty_editable| flag

This flag used to used by aura but is now only set to false. This
change removes the flag.

BUG=
==========

to

==========
Remove unnecessary |show_on_tap_for_empty_editable| flag

This flag used to used by aura but is now only set to false. This
change removes the flag.

BUG=636481
==========

[amaralp, 2016-08-10 18:59:25]

PTAL, I don't think that the failed tests are related to my change.

[commit-bot: I haz the power, 2016-08-10 19:12:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-10 19:12:52]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[aelias_OOO_until_Jul13, 2016-08-10 19:42:33]

aelias@chromium.org changed reviewers:
+ mohsen@chromium.org

[aelias_OOO_until_Jul13, 2016-08-10 19:42:34]

lgtm, adding mohsen@ for OWNERS.

[mohsen, 2016-08-10 21:09:54]

LGTM with a nit. Thanks

https://codereview.chromium.org/2230413002/diff/1/ui/touch_selection/touch_se...
File ui/touch_selection/touch_selection_controller_unittest.cc (right):

https://codereview.chromium.org/2230413002/diff/1/ui/touch_selection/touch_se...
ui/touch_selection/touch_selection_controller_unittest.cc:291:
TEST_F(TouchSelectionControllerTest, InsertionWithNoShowOnTapForEmptyEditable) {
nit: Please remove the reference to the removed flag from the test name (e.g.
InsertionForEmptyEditable?).

[amaralp, 2016-08-10 21:16:10]

The CQ bit was checked by amaralp@chromium.org

[amaralp, 2016-08-10 21:16:11]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org,
mohsen@chromium.org
Link to the patchset: https://codereview.chromium.org/2230413002/#ps20001
(title: "fixing naming nit")

[commit-bot: I haz the power, 2016-08-10 21:17:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 00:03:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 00:03:41]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[mohsen, 2016-08-11 17:52:10]

https://codereview.chromium.org/2230413002/diff/20001/ui/touch_selection/touc...
File ui/touch_selection/touch_selection_controller_unittest.cc (right):

https://codereview.chromium.org/2230413002/diff/20001/ui/touch_selection/touc...
ui/touch_selection/touch_selection_controller_unittest.cc:291:
TEST_F(TouchSelectionControllerTest, InsertionNotShownForEmptyEditable) {
Insertion is not shown for empty editables only on "tap". "Long-press" would
show insertion for empty editables (and both of these cases are tested here).

[amaralp, 2016-08-11 18:10:28]

The CQ bit was checked by amaralp@chromium.org

[amaralp, 2016-08-11 18:10:41]

The CQ bit was unchecked by amaralp@chromium.org

[amaralp, 2016-08-11 18:13:05]

The CQ bit was checked by amaralp@chromium.org

[amaralp, 2016-08-11 18:13:06]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org,
mohsen@chromium.org
Link to the patchset: https://codereview.chromium.org/2230413002/#ps40001
(title: "fixing test name")

[commit-bot: I haz the power, 2016-08-11 18:14:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 21:15:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 21:15:09]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[amaralp, 2016-08-15 18:58:41]

The CQ bit was checked by amaralp@chromium.org

[commit-bot: I haz the power, 2016-08-15 18:59:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 20:00:22]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-15 20:02:37]

Description was changed from

==========
Remove unnecessary |show_on_tap_for_empty_editable| flag

This flag used to used by aura but is now only set to false. This
change removes the flag.

BUG=636481
==========

to

==========
Remove unnecessary |show_on_tap_for_empty_editable| flag

This flag used to used by aura but is now only set to false. This
change removes the flag.

BUG=636481

Committed: https://crrev.com/add0668da5a805a55086676b0933da685574a0f3
Cr-Commit-Position: refs/heads/master@{#412024}
==========

[commit-bot: I haz the power, 2016-08-15 20:02:38]

Patchset 3 (id:??) landed as
https://crrev.com/add0668da5a805a55086676b0933da685574a0f3
Cr-Commit-Position: refs/heads/master@{#412024}