content/browser/renderer_host/render_widget_host_view_aura.cc - Issue 2230413002: Remove unnecessary |show_on_tap_for_empty_editable| flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 2230413002: Remove unnecessary |show_on_tap_for_empty_editable| flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixing test name Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_android.cc ('k') | ui/touch_selection/touch_selection_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_aura.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc

index e79d666fe7a93e6211f6433ad012511b275b1e1b..b56ee0e8097b3d7269b5f137bfcff14f9315beaa 100644

--- a/content/browser/renderer_host/render_widget_host_view_aura.cc

+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc

@@ -2775,7 +2775,6 @@ void RenderWidgetHostViewAura::CreateSelectionController() {

ui::GestureConfiguration::GetInstance()->long_press_time_in_ms());

tsc_config.tap_slop = ui::GestureConfiguration::GetInstance()

->max_touch_move_in_pixels_for_click();

- tsc_config.show_on_tap_for_empty_editable = false;

tsc_config.enable_longpress_drag_selection = false;

selection_controller_.reset(new ui::TouchSelectionController(

selection_controller_client_.get(), tsc_config));