Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 2230413002: Remove unnecessary |show_on_tap_for_empty_editable| flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixing test name Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_view_aura.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/render_widget_host_view_android.h" 5 #include "content/browser/renderer_host/render_widget_host_view_android.h"
6 6
7 #include <android/bitmap.h> 7 #include <android/bitmap.h>
8 8
9 #include <utility> 9 #include <utility>
10 10
(...skipping 241 matching lines...) Expand 10 before | Expand all | Expand 10 after
252 252
253 std::unique_ptr<ui::TouchSelectionController> CreateSelectionController( 253 std::unique_ptr<ui::TouchSelectionController> CreateSelectionController(
254 ui::TouchSelectionControllerClient* client, 254 ui::TouchSelectionControllerClient* client,
255 ContentViewCore* content_view_core) { 255 ContentViewCore* content_view_core) {
256 DCHECK(client); 256 DCHECK(client);
257 DCHECK(content_view_core); 257 DCHECK(content_view_core);
258 ui::TouchSelectionController::Config config; 258 ui::TouchSelectionController::Config config;
259 config.max_tap_duration = base::TimeDelta::FromMilliseconds( 259 config.max_tap_duration = base::TimeDelta::FromMilliseconds(
260 gfx::ViewConfiguration::GetLongPressTimeoutInMs()); 260 gfx::ViewConfiguration::GetLongPressTimeoutInMs());
261 config.tap_slop = gfx::ViewConfiguration::GetTouchSlopInDips(); 261 config.tap_slop = gfx::ViewConfiguration::GetTouchSlopInDips();
262 config.show_on_tap_for_empty_editable = false;
263 config.enable_adaptive_handle_orientation = 262 config.enable_adaptive_handle_orientation =
264 base::CommandLine::ForCurrentProcess()->HasSwitch( 263 base::CommandLine::ForCurrentProcess()->HasSwitch(
265 switches::kEnableAdaptiveSelectionHandleOrientation); 264 switches::kEnableAdaptiveSelectionHandleOrientation);
266 config.enable_longpress_drag_selection = 265 config.enable_longpress_drag_selection =
267 base::CommandLine::ForCurrentProcess()->HasSwitch( 266 base::CommandLine::ForCurrentProcess()->HasSwitch(
268 switches::kEnableLongpressDragSelection); 267 switches::kEnableLongpressDragSelection);
269 return base::WrapUnique(new ui::TouchSelectionController(client, config)); 268 return base::WrapUnique(new ui::TouchSelectionController(client, config));
270 } 269 }
271 270
272 std::unique_ptr<OverscrollControllerAndroid> CreateOverscrollController( 271 std::unique_ptr<OverscrollControllerAndroid> CreateOverscrollController(
(...skipping 1720 matching lines...) Expand 10 before | Expand all | Expand 10 after
1993 case ui::MotionEvent::ACTION_UP: 1992 case ui::MotionEvent::ACTION_UP:
1994 case ui::MotionEvent::ACTION_POINTER_UP: 1993 case ui::MotionEvent::ACTION_POINTER_UP:
1995 UMA_HISTOGRAM_CUSTOM_COUNTS("Event.Latency.OS.TOUCH_RELEASED", 1994 UMA_HISTOGRAM_CUSTOM_COUNTS("Event.Latency.OS.TOUCH_RELEASED",
1996 delta.InMicroseconds(), 1, 1000000, 50); 1995 delta.InMicroseconds(), 1, 1000000, 50);
1997 default: 1996 default:
1998 return; 1997 return;
1999 } 1998 }
2000 } 1999 }
2001 2000
2002 } // namespace content 2001 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_view_aura.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698