ui/touch_selection/touch_selection_controller.h - Issue 2230413002: Remove unnecessary |show_on_tap_for_empty_editable| flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/touch_selection/touch_selection_controller.h

Issue 2230413002: Remove unnecessary |show_on_tap_for_empty_editable| flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixing test name Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.cc ('k') | ui/touch_selection/touch_selection_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/touch_selection/touch_selection_controller.h

diff --git a/ui/touch_selection/touch_selection_controller.h b/ui/touch_selection/touch_selection_controller.h

index bbffc87c80dd030f7785673f2778f492a29fe98c..dd1e70eb88ef257960241c3f3376b9f834fd29bc 100644

--- a/ui/touch_selection/touch_selection_controller.h

+++ b/ui/touch_selection/touch_selection_controller.h

@@ -64,12 +64,6 @@ class UI_TOUCH_SELECTION_EXPORT TouchSelectionController

// Controls whether drag selection after a longpress is enabled.

// Defaults to false.

bool enable_longpress_drag_selection;

- // Controls whether an insertion handle is shown on a tap for an empty

- // editable text. Defauls to false.

- // TODO(mohsen): This flag used to be set to |true| on Aura. That's not the

- // case anymore and it is always |false|. Consider removing it.

- bool show_on_tap_for_empty_editable;

};

TouchSelectionController(TouchSelectionControllerClient* client,

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_aura.cc ('k') | ui/touch_selection/touch_selection_controller.cc » ('j') | no next file with comments »