Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2230183005: Add UMA for signin through NTP content suggestions. (Closed)

Created:
4 years, 4 months ago by PEConn
Modified:
4 years, 4 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, ntp-dev+reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UMA for signin through NTP content suggestions. BUG=636523 Committed: https://crrev.com/685346d8f50c8f04e81a4388e164203304f4d58c Cr-Commit-Position: refs/heads/master@{#412554}

Patch Set 1 #

Patch Set 2 : Added new signin point to inline_login_handler.cc #

Patch Set 3 : Do not record user actions in tests. #

Patch Set 4 : Merge. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -2 lines) Patch
M base/android/java/src/org/chromium/base/metrics/RecordUserAction.java View 1 2 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java View 3 chunks +5 lines, -1 line 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/signin/inline_login_handler.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M components/signin/core/browser/signin_metrics.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 2 3 2 chunks +15 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 42 (26 generated)
PEConn
bauerb@chromium.org and dgn@chromium.org: Please review changes in: chrome/android* atwilson@chromium.org: Please review changes in: signin_metrics.h asvitkine@chromium.org: ...
4 years, 4 months ago (2016-08-10 22:42:22 UTC) #2
Alexei Svitkine (slow)
lgtm
4 years, 4 months ago (2016-08-11 05:50:04 UTC) #3
Bernhard Bauer
lgtm
4 years, 4 months ago (2016-08-11 10:45:27 UTC) #4
PEConn
4 years, 4 months ago (2016-08-15 16:11:42 UTC) #14
PEConn
@torne: Could I please get an LGTM for RecordUserAction.java, my change is similar to what ...
4 years, 4 months ago (2016-08-15 16:13:07 UTC) #17
Torne
base/android LGTM
4 years, 4 months ago (2016-08-15 16:16:30 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230183005/40001
4 years, 4 months ago (2016-08-15 20:21:06 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/238271)
4 years, 4 months ago (2016-08-15 20:29:34 UTC) #27
PEConn
@rogerta: Could you please look at the changes in signin_metrics.cc
4 years, 4 months ago (2016-08-16 16:03:11 UTC) #29
PEConn
@atwilson: Could you please look at the changes to signin_metrics?
4 years, 4 months ago (2016-08-17 13:49:05 UTC) #30
Andrew T Wilson (Slow)
On 2016/08/17 13:49:05, PEConn wrote: > @atwilson: Could you please look at the changes to ...
4 years, 4 months ago (2016-08-17 13:57:59 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230183005/40001
4 years, 4 months ago (2016-08-17 14:02:18 UTC) #33
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/279511)
4 years, 4 months ago (2016-08-17 14:04:53 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230183005/60001
4 years, 4 months ago (2016-08-17 15:24:53 UTC) #38
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-17 16:27:54 UTC) #40
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 16:30:15 UTC) #42
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/685346d8f50c8f04e81a4388e164203304f4d58c
Cr-Commit-Position: refs/heads/master@{#412554}

Powered by Google App Engine
This is Rietveld 408576698