Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: chrome/browser/ui/webui/signin/inline_login_handler.cc

Issue 2230183005: Add UMA for signin through NTP content suggestions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/signin/inline_login_handler.h" 5 #include "chrome/browser/ui/webui/signin/inline_login_handler.h"
6 6
7 #include <limits.h> 7 #include <limits.h>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 base::UserMetricsAction("Signin_Signin_FromUnknownAccessPoint")); 170 base::UserMetricsAction("Signin_Signin_FromUnknownAccessPoint"));
171 break; 171 break;
172 case signin_metrics::AccessPoint::ACCESS_POINT_PASSWORD_BUBBLE: 172 case signin_metrics::AccessPoint::ACCESS_POINT_PASSWORD_BUBBLE:
173 content::RecordAction( 173 content::RecordAction(
174 base::UserMetricsAction("Signin_Signin_FromPasswordBubble")); 174 base::UserMetricsAction("Signin_Signin_FromPasswordBubble"));
175 break; 175 break;
176 case signin_metrics::AccessPoint::ACCESS_POINT_AUTOFILL_DROPDOWN: 176 case signin_metrics::AccessPoint::ACCESS_POINT_AUTOFILL_DROPDOWN:
177 content::RecordAction( 177 content::RecordAction(
178 base::UserMetricsAction("Signin_Signin_FromAutofillDropdown")); 178 base::UserMetricsAction("Signin_Signin_FromAutofillDropdown"));
179 break; 179 break;
180 case signin_metrics::AccessPoint::ACCESS_POINT_NTP_CONTENT_SUGGESTIONS:
181 content::RecordAction(
182 base::UserMetricsAction("Signin_Signin_FromNTPContentSuggestions"));
183 break;
180 case signin_metrics::AccessPoint::ACCESS_POINT_MAX: 184 case signin_metrics::AccessPoint::ACCESS_POINT_MAX:
181 NOTREACHED(); 185 NOTREACHED();
182 break; 186 break;
183 } 187 }
184 } 188 }
185 189
186 void InlineLoginHandler::ContinueHandleInitializeMessage() { 190 void InlineLoginHandler::ContinueHandleInitializeMessage() {
187 base::DictionaryValue params; 191 base::DictionaryValue params;
188 192
189 const std::string& app_locale = g_browser_process->GetApplicationLocale(); 193 const std::string& app_locale = g_browser_process->GetApplicationLocale();
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
291 295
292 void InlineLoginHandler::HandleDialogClose(const base::ListValue* args) { 296 void InlineLoginHandler::HandleDialogClose(const base::ListValue* args) {
293 Browser* browser = GetDesktopBrowser(web_ui()); 297 Browser* browser = GetDesktopBrowser(web_ui());
294 // If the dialog was opened in the User Manager browser will be null here. 298 // If the dialog was opened in the User Manager browser will be null here.
295 if (browser) 299 if (browser)
296 browser->CloseModalSigninWindow(); 300 browser->CloseModalSigninWindow();
297 301
298 // Does nothing if user manager is not showing. 302 // Does nothing if user manager is not showing.
299 UserManager::HideReauthDialog(); 303 UserManager::HideReauthDialog();
300 } 304 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698