chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java - Issue 2230183005: Add UMA for signin through NTP content suggestions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java

Issue 2230183005: Add UMA for signin through NTP content suggestions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java ('k') | chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java

index 23c15b0c13d9e4dc7492d89b2b03459ea3183589..e28690a70303180164fe442835f92049e4ab6c65 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java

@@ -42,7 +42,7 @@ public class AccountSigninActivity extends AppCompatActivity

@IntDef({SigninAccessPoint.SETTINGS, SigninAccessPoint.BOOKMARK_MANAGER,

SigninAccessPoint.RECENT_TABS, SigninAccessPoint.SIGNIN_PROMO,

- SigninAccessPoint.NTP_LINK, SigninAccessPoint.AUTOFILL_DROPDOWN})

+ SigninAccessPoint.NTP_CONTENT_SUGGESTIONS, SigninAccessPoint.AUTOFILL_DROPDOWN})

@Retention(RetentionPolicy.SOURCE)

public @interface AccessPoint {}

@AccessPoint private int mAccessPoint;

@@ -98,6 +98,7 @@ public class AccountSigninActivity extends AppCompatActivity

|| mAccessPoint == SigninAccessPoint.RECENT_TABS

|| mAccessPoint == SigninAccessPoint.SETTINGS

|| mAccessPoint == SigninAccessPoint.SIGNIN_PROMO

+ || mAccessPoint == SigninAccessPoint.NTP_CONTENT_SUGGESTIONS

|| mAccessPoint == SigninAccessPoint.AUTOFILL_DROPDOWN

: "invalid access point: " + mAccessPoint;

@@ -190,6 +191,9 @@ public class AccountSigninActivity extends AppCompatActivity

case SigninAccessPoint.SIGNIN_PROMO:

RecordUserAction.record("Signin_Signin_FromSigninPromo");

break;

+ case SigninAccessPoint.NTP_CONTENT_SUGGESTIONS:

+ RecordUserAction.record("Signin_Signin_FromNTPContentSuggestions");

+ break;

default:

assert false : "Invalid access point.";

}