chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java - Issue 2230183005: Add UMA for signin through NTP content suggestions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java

Issue 2230183005: Add UMA for signin through NTP content suggestions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/android/java/src/org/chromium/base/metrics/RecordUserAction.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/signin/AccountSigninActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java

index 615d70c487ee0acd0ec7ef2bf321cf02a96c0c63..e03b43906784a557246079bc7fc28a5a0f55c825 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/StatusItem.java

@@ -11,6 +11,7 @@ import android.widget.Button;

import android.widget.TextView;

import org.chromium.base.Log;

+import org.chromium.base.metrics.RecordUserAction;

import org.chromium.chrome.R;

import org.chromium.chrome.browser.ntp.UiConfig;

import org.chromium.chrome.browser.ntp.snippets.CategoryStatus;

@@ -86,12 +87,14 @@ public abstract class StatusItem implements NewTabPageItem {

super(R.string.snippets_disabled_generic_prompt,

R.string.snippets_disabled_signed_out_instructions,

R.string.sign_in_button);

+ RecordUserAction.record("Signin_Impression_FromNTPContentSuggestions");

Log.d(TAG, "Registering card for status: User Signed out");

}

@Override

protected void performAction(Context context) {

- AccountSigninActivity.startIfAllowed(context, SigninAccessPoint.NTP_LINK);

+ AccountSigninActivity.startIfAllowed(context,

+ SigninAccessPoint.NTP_CONTENT_SUGGESTIONS);

}