Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 2230083004: [turbolizer] Use locations rather than ranges everywhere (Closed)

Created:
4 years, 4 months ago by danno
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbolizer] Use locations rather than ranges everywhere Also convert CodeView to a class and fix a host of selection bugs in the process, as well as move the logic and data to "enrich" location with one type of location data with location data known globally to the whole graph in the selection broker. Committed: https://crrev.com/d3905561b9e27ea91860077be4c4293a3fb53db4 Cr-Commit-Position: refs/heads/master@{#38544}

Patch Set 1 #

Patch Set 2 : [turbolizer] Use locations rather than ranges everywhere #

Patch Set 3 : Remove stray change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -293 lines) Patch
M tools/turbolizer/code-view.js View 1 chunk +143 lines, -149 lines 0 comments Download
M tools/turbolizer/disassembly-view.js View 1 2 chunks +11 lines, -4 lines 0 comments Download
M tools/turbolizer/graph-view.js View 1 3 chunks +9 lines, -8 lines 0 comments Download
M tools/turbolizer/schedule-view.js View 3 chunks +5 lines, -4 lines 0 comments Download
M tools/turbolizer/selection.js View 2 chunks +2 lines, -1 line 0 comments Download
M tools/turbolizer/selection-broker.js View 1 chunk +59 lines, -6 lines 0 comments Download
M tools/turbolizer/text-view.js View 1 7 chunks +10 lines, -117 lines 0 comments Download
M tools/turbolizer/turbo-visualizer.js View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tools/turbolizer/view.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
danno
ptal
4 years, 4 months ago (2016-08-10 11:50:23 UTC) #5
Michael Starzinger
LGTM (rubber-stamp).
4 years, 4 months ago (2016-08-10 14:15:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2230083004/40001
4 years, 4 months ago (2016-08-10 14:23:56 UTC) #8
bgeron
lgtm
4 years, 4 months ago (2016-08-10 14:39:11 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-10 14:46:04 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 14:46:19 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d3905561b9e27ea91860077be4c4293a3fb53db4
Cr-Commit-Position: refs/heads/master@{#38544}

Powered by Google App Engine
This is Rietveld 408576698