Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: tools/turbolizer/disassembly-view.js

Issue 2230083004: [turbolizer] Use locations rather than ranges everywhere (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove stray change Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/turbolizer/code-view.js ('k') | tools/turbolizer/graph-view.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/turbolizer/disassembly-view.js
diff --git a/tools/turbolizer/disassembly-view.js b/tools/turbolizer/disassembly-view.js
index 737437c16d175a79a6947b57fbf137cad7b70e75..b704c773123a780e0c2ccc79029dd7831c4fd1f4 100644
--- a/tools/turbolizer/disassembly-view.js
+++ b/tools/turbolizer/disassembly-view.js
@@ -5,7 +5,7 @@
"use strict";
class DisassemblyView extends TextView {
- constructor(id, broker, sortedPositionList) {
+ constructor(id, broker) {
super(id, broker, null, false);
let view = this;
@@ -40,9 +40,16 @@ class DisassemblyView extends TextView {
let OPCODE_STYLE = {
css: 'kwd',
location: function(text) {
- return {
- address: ADDRESS_STYLE.last_address
- };
+ if (BLOCK_HEADER_STYLE.block_id != undefined) {
+ return {
+ address: ADDRESS_STYLE.last_address,
+ block_id: BLOCK_HEADER_STYLE.block_id
+ };
+ } else {
+ return {
+ address: ADDRESS_STYLE.last_address
+ };
+ }
}
};
const BLOCK_HEADER_STYLE = {
« no previous file with comments | « tools/turbolizer/code-view.js ('k') | tools/turbolizer/graph-view.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698