Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1473)

Unified Diff: tools/turbolizer/schedule-view.js

Issue 2230083004: [turbolizer] Use locations rather than ranges everywhere (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove stray change Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/turbolizer/graph-view.js ('k') | tools/turbolizer/selection.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/turbolizer/schedule-view.js
diff --git a/tools/turbolizer/schedule-view.js b/tools/turbolizer/schedule-view.js
index 00ce20544181538f8de49640900b10cc842e0e6d..2cd49c991fdd5d70bf96e3849a53cb1fd527fddb 100644
--- a/tools/turbolizer/schedule-view.js
+++ b/tools/turbolizer/schedule-view.js
@@ -5,7 +5,7 @@
"use strict";
class ScheduleView extends TextView {
- constructor(id, broker, nodePositionMap) {
+ constructor(id, broker) {
super(id, broker, null, false);
let view = this;
let BLOCK_STYLE = {
@@ -103,7 +103,6 @@ class ScheduleView extends TextView {
]
];
this.setPatterns(patterns);
- this.setNodePositionMap(nodePositionMap);
}
initializeContent(data, rememberedSelection) {
@@ -113,14 +112,16 @@ class ScheduleView extends TextView {
for (var id of rememberedSelection) {
locations.push({ node_id : id });
}
- this.selectLocations(locations, true, false);
+ this.selectLocations(locations, true, true);
}
detachSelection() {
var selection = this.selection.detachSelection();
var s = new Set();
for (var i of selection) {
- s.add(i.location.node_id);
+ if (i.location.node_id != undefined && i.location.node_id > 0) {
+ s.add(i.location.node_id);
+ }
};
return s;
}
« no previous file with comments | « tools/turbolizer/graph-view.js ('k') | tools/turbolizer/selection.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698