Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: tools/turbolizer/turbo-visualizer.js

Issue 2230083004: [turbolizer] Use locations rather than ranges everywhere (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove stray change Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/turbolizer/text-view.js ('k') | tools/turbolizer/view.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/turbolizer/turbo-visualizer.js
diff --git a/tools/turbolizer/turbo-visualizer.js b/tools/turbolizer/turbo-visualizer.js
index 0c553d48b5f029a785ba033c5ce0ad40646d1dde..f0cb9e25f5daab2d43ee1917d0d32d6724b00735 100644
--- a/tools/turbolizer/turbo-visualizer.js
+++ b/tools/turbolizer/turbo-visualizer.js
@@ -170,9 +170,10 @@ document.onload = (function(d3){
hideCurrentPhase();
+ selectionBroker.setNodePositionMap(jsonObj.nodePositions);
+
sourceView.initializeCode(jsonObj.source, jsonObj.sourcePosition);
- disassemblyView.initializeCode(jsonObj.source, jsonObj.sourcePosition);
- schedule.setNodePositionMap(jsonObj.nodePositions);
+ disassemblyView.initializeCode(jsonObj.source);
var selectMenu = document.getElementById('display-selector');
var disassemblyPhase = null;
@@ -195,7 +196,6 @@ document.onload = (function(d3){
eventMenu.add(optionElement, null);
}
disassemblyView.initializePerfProfile(jsonObj.eventCounts);
- disassemblyView.setNodePositionMap(jsonObj.nodePositions);
disassemblyView.show(disassemblyPhase.data, null);
var initialPhaseIndex = +window.sessionStorage.getItem("lastSelectedPhase");
« no previous file with comments | « tools/turbolizer/text-view.js ('k') | tools/turbolizer/view.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698