Mojo C++ bindings: add test cases for union custom typemapping.

Mojo C++ bindings: add test cases for union custom typemapping.

And also fix minor issues in union Serializer code.

BUG=577686
Committed: https://crrev.com/6c5ed99db17ce0c35774c8c7dec1106d711be38d
Cr-Commit-Position: refs/heads/master@{#410503}

[yzshen1, 2016-08-08 22:58:41]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 22:59:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2016-08-08 22:59:34]

yzshen@chromium.org changed reviewers:
+ rockot@chromium.org

[yzshen1, 2016-08-08 22:59:35]

Hi, Ken.

Would you please take a look? Thanks!

[Fady Samuel, 2016-08-08 23:02:46]

fsamuel@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2016-08-08 23:02:46]

https://codereview.chromium.org/2228733002/diff/1/mojo/public/interfaces/bind...
File mojo/public/interfaces/bindings/tests/struct_with_traits.mojom (right):

https://codereview.chromium.org/2228733002/diff/1/mojo/public/interfaces/bind...
mojo/public/interfaces/bindings/tests/struct_with_traits.mojom:81:
EchoUnionWithTraits(UnionWithTraits u) => (UnionWithTraits passed);
optional nit: I've found tests are a lot more readable if this is [Sync].

[yzshen1, 2016-08-08 23:07:38]

https://codereview.chromium.org/2228733002/diff/1/mojo/public/interfaces/bind...
File mojo/public/interfaces/bindings/tests/struct_with_traits.mojom (right):

https://codereview.chromium.org/2228733002/diff/1/mojo/public/interfaces/bind...
mojo/public/interfaces/bindings/tests/struct_with_traits.mojom:81:
EchoUnionWithTraits(UnionWithTraits u) => (UnionWithTraits passed);
On 2016/08/08 23:02:46, Fady Samuel wrote:
> optional nit: I've found tests are a lot more readable if this is [Sync].

Yeah, that is probably true.

If you don't mind, I would like to leave this unchanged to be more consistent
with the other test cases in the same file.

WDYT?
Thanks!

[Ken Rockot(use gerrit already), 2016-08-08 23:08:26]

lgtm

[Fady Samuel, 2016-08-08 23:09:04]

https://codereview.chromium.org/2228733002/diff/1/mojo/public/interfaces/bind...
File mojo/public/interfaces/bindings/tests/struct_with_traits.mojom (right):

https://codereview.chromium.org/2228733002/diff/1/mojo/public/interfaces/bind...
mojo/public/interfaces/bindings/tests/struct_with_traits.mojom:81:
EchoUnionWithTraits(UnionWithTraits u) => (UnionWithTraits passed);
On 2016/08/08 23:07:38, yzshen1 wrote:
> On 2016/08/08 23:02:46, Fady Samuel wrote:
> > optional nit: I've found tests are a lot more readable if this is [Sync].
> 
> Yeah, that is probably true.
> 
> If you don't mind, I would like to leave this unchanged to be more consistent
> with the other test cases in the same file.
> 
> WDYT?
> Thanks!

Yea, of course, no problem. lgtm

[commit-bot: I haz the power, 2016-08-08 23:15:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 23:15:05]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[yzshen1, 2016-08-08 23:17:30]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2016-08-08 23:18:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 23:58:08]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-09 00:00:32]

Description was changed from

==========
Mojo C++ bindings: add test cases for union custom typemapping.

And also fix minor issues in union Serializer code.

BUG=577686
==========

to

==========
Mojo C++ bindings: add test cases for union custom typemapping.

And also fix minor issues in union Serializer code.

BUG=577686

Committed: https://crrev.com/6c5ed99db17ce0c35774c8c7dec1106d711be38d
Cr-Commit-Position: refs/heads/master@{#410503}
==========

[commit-bot: I haz the power, 2016-08-09 00:00:33]

Patchset 1 (id:??) landed as
https://crrev.com/6c5ed99db17ce0c35774c8c7dec1106d711be38d
Cr-Commit-Position: refs/heads/master@{#410503}