Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2228733002: Mojo C++ bindings: add test cases for union custom typemapping. (Closed)

Created:
4 years, 4 months ago by yzshen1
Modified:
4 years, 4 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), Fady Samuel, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@86_union_traits
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: add test cases for union custom typemapping. And also fix minor issues in union Serializer code. BUG=577686 Committed: https://crrev.com/6c5ed99db17ce0c35774c8c7dec1106d711be38d Cr-Commit-Position: refs/heads/master@{#410503}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -2 lines) Patch
M mojo/public/cpp/bindings/tests/struct_traits_unittest.cc View 2 chunks +52 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/struct_with_traits.typemap View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/struct_with_traits_impl.h View 1 chunk +41 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/struct_with_traits_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.h View 1 chunk +47 lines, -0 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/struct_with_traits.mojom View 2 chunks +7 lines, -0 lines 3 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/union_serialization_declaration.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (8 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
4 years, 4 months ago (2016-08-08 22:59:35 UTC) #4
Fady Samuel
https://codereview.chromium.org/2228733002/diff/1/mojo/public/interfaces/bindings/tests/struct_with_traits.mojom File mojo/public/interfaces/bindings/tests/struct_with_traits.mojom (right): https://codereview.chromium.org/2228733002/diff/1/mojo/public/interfaces/bindings/tests/struct_with_traits.mojom#newcode81 mojo/public/interfaces/bindings/tests/struct_with_traits.mojom:81: EchoUnionWithTraits(UnionWithTraits u) => (UnionWithTraits passed); optional nit: I've found ...
4 years, 4 months ago (2016-08-08 23:02:46 UTC) #6
yzshen1
https://codereview.chromium.org/2228733002/diff/1/mojo/public/interfaces/bindings/tests/struct_with_traits.mojom File mojo/public/interfaces/bindings/tests/struct_with_traits.mojom (right): https://codereview.chromium.org/2228733002/diff/1/mojo/public/interfaces/bindings/tests/struct_with_traits.mojom#newcode81 mojo/public/interfaces/bindings/tests/struct_with_traits.mojom:81: EchoUnionWithTraits(UnionWithTraits u) => (UnionWithTraits passed); On 2016/08/08 23:02:46, Fady ...
4 years, 4 months ago (2016-08-08 23:07:38 UTC) #7
Ken Rockot(use gerrit already)
lgtm
4 years, 4 months ago (2016-08-08 23:08:26 UTC) #8
Fady Samuel
https://codereview.chromium.org/2228733002/diff/1/mojo/public/interfaces/bindings/tests/struct_with_traits.mojom File mojo/public/interfaces/bindings/tests/struct_with_traits.mojom (right): https://codereview.chromium.org/2228733002/diff/1/mojo/public/interfaces/bindings/tests/struct_with_traits.mojom#newcode81 mojo/public/interfaces/bindings/tests/struct_with_traits.mojom:81: EchoUnionWithTraits(UnionWithTraits u) => (UnionWithTraits passed); On 2016/08/08 23:07:38, yzshen1 ...
4 years, 4 months ago (2016-08-08 23:09:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228733002/1
4 years, 4 months ago (2016-08-08 23:18:14 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 23:58:08 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 00:00:33 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c5ed99db17ce0c35774c8c7dec1106d711be38d
Cr-Commit-Position: refs/heads/master@{#410503}

Powered by Google App Engine
This is Rietveld 408576698