Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 2229793003: Mojo C++ bindings: change union reader of struct data view to be a template. (Closed)

Created:
4 years, 4 months ago by yzshen1
Modified:
4 years, 4 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@87_union_typemapping
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: change union reader of struct data view to be a template. BUG=577686 Committed: https://crrev.com/b3e6e55f9a47398985c433f65171bc37b4230a08 Cr-Commit-Position: refs/heads/master@{#410804}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M mojo/public/tools/bindings/generators/cpp_templates/struct_data_view_declaration.tmpl View 2 chunks +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (9 generated)
yzshen1
Hi, Fady. Please take a look! Thanks!
4 years, 4 months ago (2016-08-09 16:48:39 UTC) #3
Fady Samuel
lgtm
4 years, 4 months ago (2016-08-09 16:51:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2229793003/1
4 years, 4 months ago (2016-08-09 16:51:54 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/270074)
4 years, 4 months ago (2016-08-09 19:12:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2229793003/1
4 years, 4 months ago (2016-08-09 19:44:46 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 20:40:52 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 20:42:46 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b3e6e55f9a47398985c433f65171bc37b4230a08
Cr-Commit-Position: refs/heads/master@{#410804}

Powered by Google App Engine
This is Rietveld 408576698