Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2226853002: Mojo C++ bindings: add support for UnionTraits. (Closed)

Created:
4 years, 4 months ago by yzshen1
Modified:
4 years, 4 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@85_10_inline_more
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: add support for UnionTraits. BUG=577686 Committed: https://crrev.com/95c174b32a64066c1650fe7b8ae7f5bf417cdb18 Cr-Commit-Position: refs/heads/master@{#410489}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+327 lines, -213 lines) Patch
M mojo/public/cpp/bindings/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/serialization_forward.h View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/public/cpp/bindings/union_traits.h View 1 chunk +35 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/enum_serialization_declaration.tmpl View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/union_data_view_declaration.tmpl View 1 2 1 chunk +68 lines, -5 lines 0 comments Download
A mojo/public/tools/bindings/generators/cpp_templates/union_data_view_definition.tmpl View 1 chunk +12 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/union_declaration.tmpl View 1 1 chunk +11 lines, -8 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/union_definition.tmpl View 1 1 chunk +0 lines, -10 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/union_serialization_declaration.tmpl View 1 2 1 chunk +150 lines, -18 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/union_serialization_definition.tmpl View 1 chunk +31 lines, -153 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/wrapper_union_class_declaration.tmpl View 1 2 1 chunk +12 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/wrapper_union_class_definition.tmpl View 1 chunk +0 lines, -14 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_cpp_generator.py View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (12 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
4 years, 4 months ago (2016-08-08 19:48:16 UTC) #3
Ken Rockot(use gerrit already)
lgtm
4 years, 4 months ago (2016-08-08 20:33:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226853002/40001
4 years, 4 months ago (2016-08-08 21:55:41 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-08 23:12:39 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 23:16:02 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/95c174b32a64066c1650fe7b8ae7f5bf417cdb18
Cr-Commit-Position: refs/heads/master@{#410489}

Powered by Google App Engine
This is Rietveld 408576698