mojo/public/interfaces/bindings/tests/struct_with_traits.mojom - Issue 2228733002: Mojo C++ bindings: add test cases for union custom typemapping.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/interfaces/bindings/tests/struct_with_traits.mojom

Issue 2228733002: Mojo C++ bindings: add test cases for union custom typemapping. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@86_union_traits

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/cpp/bindings/tests/struct_with_traits_impl_traits.h ('k') | mojo/public/tools/bindings/generators/cpp_templates/union_serialization_declaration.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/interfaces/bindings/tests/struct_with_traits.mojom

diff --git a/mojo/public/interfaces/bindings/tests/struct_with_traits.mojom b/mojo/public/interfaces/bindings/tests/struct_with_traits.mojom

index 955fb08b7c34f5ed8305d16878cbd16a982f1402..ac41df7cdddf67f813173a7c2b62546dbdac7c71 100644

--- a/mojo/public/interfaces/bindings/tests/struct_with_traits.mojom

+++ b/mojo/public/interfaces/bindings/tests/struct_with_traits.mojom

@@ -53,6 +53,11 @@ struct StructWithTraitsForUniquePtr {

int32 f_int32;

};

+union UnionWithTraits {

+ int32 f_int32;

+ NestedStructWithTraits f_struct;

+};

interface TraitsTestService {

EchoStructWithTraits(StructWithTraits s) => (StructWithTraits passed);

@@ -72,4 +77,6 @@ interface TraitsTestService {

EchoNullableStructWithTraitsForUniquePtr(StructWithTraitsForUniquePtr? e) => (

StructWithTraitsForUniquePtr? passed);

+ EchoUnionWithTraits(UnionWithTraits u) => (UnionWithTraits passed);

Fady Samuel 2016/08/08 23:02:46 optional nit: I've found tests are a lot more read

yzshen1 2016/08/08 23:07:38 Yeah, that is probably true. If you don't mind, I

Fady Samuel 2016/08/08 23:09:03 Yea, of course, no problem. lgtm

};