Settings Router Refactor: Remove subpage-back.

Settings Router Refactor: Remove subpage-back.

BUG=632382
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/cf72a2e8783b5438ed796f78a1e3dcd31afa23d0
Cr-Commit-Position: refs/heads/master@{#410692}

[tommycli, 2016-08-08 19:22:17]

Description was changed from

==========
Settings Router Refactor: Remove subpage-back.

BUG=632382
==========

to

==========
Settings Router Refactor: Remove subpage-back.

BUG=632382
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2016-08-08 19:22:19]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 19:23:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2016-08-08 19:26:57]

tommycli@chromium.org changed reviewers:
+ dbeam@chromium.org

[tommycli, 2016-08-08 19:26:57]

dbeam: PTAL remove subpage-back

[commit-bot: I haz the power, 2016-08-08 19:30:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 19:30:42]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Dan Beam, 2016-08-09 02:33:10]

lgtm i guess

are we eventually going to preserve scroll position?  i feel like we do a bad
job at this currently...

[tommycli, 2016-08-09 15:56:24]

On 2016/08/09 02:33:10, Dan Beam wrote:
> lgtm i guess
> 
> are we eventually going to preserve scroll position?  i feel like we do a bad
> job at this currently...

Ahhh... I think we could, but the router doesn't directly know the scroll pos.
It would need some kind of hook into one of the settings-main or
MainPageBehavior elements.

[tommycli, 2016-08-09 15:56:29]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-08-09 15:57:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 16:09:02]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-09 16:11:46]

Description was changed from

==========
Settings Router Refactor: Remove subpage-back.

BUG=632382
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Settings Router Refactor: Remove subpage-back.

BUG=632382
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/cf72a2e8783b5438ed796f78a1e3dcd31afa23d0
Cr-Commit-Position: refs/heads/master@{#410692}
==========

[commit-bot: I haz the power, 2016-08-09 16:11:47]

Patchset 1 (id:??) landed as
https://crrev.com/cf72a2e8783b5438ed796f78a1e3dcd31afa23d0
Cr-Commit-Position: refs/heads/master@{#410692}

[Finnur, 2016-08-23 13:04:17]

finnur@chromium.org changed reviewers:
+ finnur@chromium.org

[Finnur, 2016-08-23 13:04:18]

https://codereview.chromium.org/2226003002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/site_settings/site_details.js (right):

https://codereview.chromium.org/2226003002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/site_settings/site_details.js:92:
settings.navigateTo(settings.Route.SITE_SETTINGS_ALL);
Hmmm... This is a bit problematic... :/

When you open some category, then enter Site Details and click 'Clear and
Reset', the page should navigate back to the category you used to get to the
Site Details page. Instead it goes to the All Sites page, which is weird.

See first video in this bug:
http://crbug.com/639208

[tommycli, 2016-08-23 16:35:28]

https://codereview.chromium.org/2226003002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/site_settings/site_details.js (right):

https://codereview.chromium.org/2226003002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/site_settings/site_details.js:92:
settings.navigateTo(settings.Route.SITE_SETTINGS_ALL);
On 2016/08/23 13:04:17, Finnur wrote:
> Hmmm... This is a bit problematic... :/
> 
> When you open some category, then enter Site Details and click 'Clear and
> Reset', the page should navigate back to the category you used to get to the
> Site Details page. Instead it goes to the All Sites page, which is weird.
> 
> See first video in this bug:
> http://crbug.com/639208

Try changing it to settings.navigateToPreviousRoute(). Does that fix it?

[Finnur, 2016-08-24 11:39:45]

Yup. Thanks!