chrome/browser/resources/settings/internet_page/internet_detail_page.js - Issue 2226003002: Settings Router Refactor: Remove subpage-back.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/internet_page/internet_detail_page.js

Issue 2226003002: Settings Router Refactor: Remove subpage-back. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/internet_page/internet_detail_page.html ('k') | chrome/browser/resources/settings/settings_page/settings_animated_pages.js » ('j') | chrome/browser/resources/settings/site_settings/site_details.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/internet_page/internet_detail_page.js

diff --git a/chrome/browser/resources/settings/internet_page/internet_detail_page.js b/chrome/browser/resources/settings/internet_page/internet_detail_page.js

index 598a02a94f2e8239eaa3d4c26a85ba5f6162689f..b8dbbd4b92eaf96eebb79536a549bf2f316b873e 100644

--- a/chrome/browser/resources/settings/internet_page/internet_detail_page.js

+++ b/chrome/browser/resources/settings/internet_page/internet_detail_page.js

@@ -127,11 +127,9 @@ Polymer({

/** @private */

close_: function() {

- // Delay sending subpage-back until the next render frame to allow other

- // subpages to load first.

- setTimeout(function() {

- this.fire('subpage-back');

- }.bind(this));

+ // Delay navigating until the next render frame to allow other subpages to

+ // load first.

+ setTimeout(function() { settings.navigateTo(settings.Route.INTERNET) });

/** @private */