chrome/browser/resources/settings/settings_page/settings_animated_pages.js - Issue 2226003002: Settings Router Refactor: Remove subpage-back.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_page/settings_animated_pages.js

Issue 2226003002: Settings Router Refactor: Remove subpage-back. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/internet_page/internet_detail_page.js ('k') | chrome/browser/resources/settings/site_settings/compiled_resources2.gyp » ('j') | chrome/browser/resources/settings/site_settings/site_details.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_page/settings_animated_pages.js

diff --git a/chrome/browser/resources/settings/settings_page/settings_animated_pages.js b/chrome/browser/resources/settings/settings_page/settings_animated_pages.js

index 682ead2dc14c8c474601fbe74938ce5aba6b00c1..d48ed482723c9631e18cb6b242c4d91d3af0f853 100644

--- a/chrome/browser/resources/settings/settings_page/settings_animated_pages.js

+++ b/chrome/browser/resources/settings/settings_page/settings_animated_pages.js

@@ -36,12 +36,6 @@ Polymer({

// Observe the light DOM so we know when it's ready.

this.lightDomObserver_ = Polymer.dom(this).observeNodes(

this.lightDomChanged_.bind(this));

- this.addEventListener('subpage-back', function() {

- var parent = settings.getCurrentRoute().parent;

- assert(parent);

- settings.navigateTo(parent);

- }.bind(this));

/**