chrome/browser/resources/settings/site_settings/site_details.js - Issue 2226003002: Settings Router Refactor: Remove subpage-back.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings/site_details.js

Issue 2226003002: Settings Router Refactor: Remove subpage-back. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/site_settings/site_details.js

diff --git a/chrome/browser/resources/settings/site_settings/site_details.js b/chrome/browser/resources/settings/site_settings/site_details.js

index 980dc6e3b24b5734ba380a853e4dd9dc03697232..0e659b2457aa9796975062e7ad37c8d7cd29ecfc 100644

--- a/chrome/browser/resources/settings/site_settings/site_details.js

+++ b/chrome/browser/resources/settings/site_settings/site_details.js

@@ -89,7 +89,7 @@ Polymer({

navigateBackIfNoData_: function() {

if (this.storedData_ == '' && !this.permissionShowing_())

- this.fire('subpage-back');

+ settings.navigateTo(settings.Route.SITE_SETTINGS_ALL);

Finnur 2016/08/23 13:04:17 Hmmm... This is a bit problematic... :/ When you

tommycli 2016/08/23 16:35:28 Try changing it to settings.navigateToPreviousRout

/**

« no previous file with comments | « chrome/browser/resources/settings/site_settings/site_details.html ('k') | no next file » | no next file with comments »