WaveShaperNode should copy its curve.

WaveShaperNode should copy its curve.

When setting the curve attribute for a WaveShaperNode, changes to the
curve should NOT modify the output of the node.  Hence, copy the curve
data to an internal buffer so that changes won't be propagated.

BUG=635052
TEST=waveshaper-copy-curve.html

Committed: https://crrev.com/7b93c871846de69e79de9c0ffb9fd6a7f3802be7
Cr-Commit-Position: refs/heads/master@{#411658}

[Raymond Toy, 2016-08-05 22:57:26]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 22:57:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Raymond Toy, 2016-08-05 23:14:20]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 23:14:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-06 00:23:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-06 00:23:24]

Dry run: This issue passed the CQ dry run.

[Raymond Toy, 2016-08-08 16:22:53]

Description was changed from

==========
WaveShaperNode should copy its curve.

When setting the curve attribute for a WaveShaperNode, changes to the
curve should modify the output of the node.  Hence, copy the curve
data to an internal buffer so that changes won't be propagated.

BUG=635052
TEST=waveshaper-copy-curve.html
==========

to

==========
WaveShaperNode should copy its curve.

When setting the curve attribute for a WaveShaperNode, changes to the
curve should NOT modify the output of the node.  Hence, copy the curve
data to an internal buffer so that changes won't be propagated.

BUG=635052
TEST=waveshaper-copy-curve.html
==========

[Raymond Toy, 2016-08-08 16:47:34]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 16:47:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 18:13:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 18:14:00]

Dry run: This issue passed the CQ dry run.

[Raymond Toy, 2016-08-08 21:24:39]

https://codereview.chromium.org/2223613002/diff/50001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js (right):

https://codereview.chromium.org/2223613002/diff/50001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js:1148:
ShouldModel.prototype.beNull = function () {
Maybe we don't want this and have the user use beEqualTo (once that is made to
accept booleans).

[Raymond Toy, 2016-08-10 16:58:08]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2016-08-10 16:58:09]

PTAL.

[hongchan, 2016-08-11 18:48:58]

Please use 'taskDone' inside of the Audit task runner. done() will trigger the
method of testharness, causing the test to end prematurely.

https://codereview.chromium.org/2223613002/diff/50001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/waveshaper-copy-curve.html (right):

https://codereview.chromium.org/2223613002/diff/50001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/waveshaper-copy-curve.html:7: <script
src="resources/compatibility.js"></script>
Let's remove this. We don't need this any more.

https://codereview.chromium.org/2223613002/diff/50001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/waveshaper-copy-curve.html:66: // Let's
go!
Seems unnecessary, but I'll leave it up to you.

https://codereview.chromium.org/2223613002/diff/50001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/waveshaper-simple.html (right):

https://codereview.chromium.org/2223613002/diff/50001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/waveshaper-simple.html:7: <script
src="resources/compatibility.js"></script>
Ditto.

https://codereview.chromium.org/2223613002/diff/70001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js (right):

https://codereview.chromium.org/2223613002/diff/70001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/resources/audio-testing.js:610: 'value
should be number or string for', value);
'value should be number, string or boolean for'

https://codereview.chromium.org/2223613002/diff/70001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/waveshaper-copy-curve.html (right):

https://codereview.chromium.org/2223613002/diff/70001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/waveshaper-copy-curve.html:18:
audit.defineTask("test copying", function (done) {
function (taskDone)

https://codereview.chromium.org/2223613002/diff/70001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/waveshaper-copy-curve.html:81:
}).then(done);
.then(taskDone);

https://codereview.chromium.org/2223613002/diff/70001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/waveshaper-simple.html (right):

https://codereview.chromium.org/2223613002/diff/70001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/waveshaper-simple.html:7: <script
src="resources/compatibility.js"></script>
I suggest to remove this check.

https://codereview.chromium.org/2223613002/diff/70001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/waveshaper-simple.html:15:
audit.defineTask("simple", function () {
function (taskDone) {

https://codereview.chromium.org/2223613002/diff/70001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/waveshaper-simple.html:43: done();
This is wrong. This will finish the testharness, not Audit task runner. Use
taskDone(). See line 15.

[Raymond Toy, 2016-08-11 20:11:48]

https://codereview.chromium.org/2223613002/diff/50001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/waveshaper-copy-curve.html (right):

https://codereview.chromium.org/2223613002/diff/50001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/waveshaper-copy-curve.html:7: <script
src="resources/compatibility.js"></script>
On 2016/08/11 18:48:58, hoch wrote:
> Let's remove this. We don't need this any more.

Done.

https://codereview.chromium.org/2223613002/diff/50001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/waveshaper-copy-curve.html:66: // Let's
go!
On 2016/08/11 18:48:58, hoch wrote:
> Seems unnecessary, but I'll leave it up to you.

Done.

https://codereview.chromium.org/2223613002/diff/50001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/waveshaper-simple.html (right):

https://codereview.chromium.org/2223613002/diff/50001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/waveshaper-simple.html:7: <script
src="resources/compatibility.js"></script>
On 2016/08/11 18:48:58, hoch wrote:
> Ditto.

Done.

[hongchan, 2016-08-12 01:18:05]

lgtm

[hongchan, 2016-08-12 01:19:47]

The CQ bit was checked by hongchan@chromium.org

[commit-bot: I haz the power, 2016-08-12 01:20:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 02:15:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 02:15:26]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Raymond Toy, 2016-08-12 15:07:36]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2016-08-12 15:07:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 15:36:40]

Committed patchset #6 (id:90001)

[commit-bot: I haz the power, 2016-08-12 15:38:29]

Description was changed from

==========
WaveShaperNode should copy its curve.

When setting the curve attribute for a WaveShaperNode, changes to the
curve should NOT modify the output of the node.  Hence, copy the curve
data to an internal buffer so that changes won't be propagated.

BUG=635052
TEST=waveshaper-copy-curve.html
==========

to

==========
WaveShaperNode should copy its curve.

When setting the curve attribute for a WaveShaperNode, changes to the
curve should NOT modify the output of the node.  Hence, copy the curve
data to an internal buffer so that changes won't be propagated.

BUG=635052
TEST=waveshaper-copy-curve.html

Committed: https://crrev.com/7b93c871846de69e79de9c0ffb9fd6a7f3802be7
Cr-Commit-Position: refs/heads/master@{#411658}
==========

[commit-bot: I haz the power, 2016-08-12 15:38:30]

Patchset 6 (id:??) landed as
https://crrev.com/7b93c871846de69e79de9c0ffb9fd6a7f3802be7
Cr-Commit-Position: refs/heads/master@{#411658}