third_party/WebKit/Source/modules/webaudio/WaveShaperProcessor.h - Issue 2223613002: WaveShaperNode should copy its curve.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/WaveShaperProcessor.h

Issue 2223613002: WaveShaperNode should copy its curve. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webaudio/WaveShaperProcessor.h

diff --git a/third_party/WebKit/Source/modules/webaudio/WaveShaperProcessor.h b/third_party/WebKit/Source/modules/webaudio/WaveShaperProcessor.h

index b6b67087b57647257758751e1441227ecb7fb2e4..024d3373882fa026d38584b9fed45986d3cebcb7 100644

--- a/third_party/WebKit/Source/modules/webaudio/WaveShaperProcessor.h

+++ b/third_party/WebKit/Source/modules/webaudio/WaveShaperProcessor.h

@@ -54,14 +54,14 @@ public:

void process(const AudioBus* source, AudioBus* destination, size_t framesToProcess) override;

void setCurve(DOMFloat32Array*);

- DOMFloat32Array* curve() { return m_curve.get(); }

+ Vector<float>* curve() const { return m_curve.get(); };

void setOversample(OverSampleType);

OverSampleType oversample() const { return m_oversample; }

private:

// m_curve represents the non-linear shaping curve.

- CrossThreadPersistent<DOMFloat32Array> m_curve;

+ std::unique_ptr<Vector<float>> m_curve;

OverSampleType m_oversample;

};