Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: third_party/WebKit/Source/modules/webaudio/WaveShaperNode.cpp

Issue 2223613002: WaveShaperNode should copy its curve. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/WaveShaperNode.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/WaveShaperNode.cpp b/third_party/WebKit/Source/modules/webaudio/WaveShaperNode.cpp
index c0046ed6be52bd0d75837b9971810c644c701c62..e4d9ba1e094d483e6aca15a411df168e28104339 100644
--- a/third_party/WebKit/Source/modules/webaudio/WaveShaperNode.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/WaveShaperNode.cpp
@@ -76,7 +76,16 @@ void WaveShaperNode::setCurve(DOMFloat32Array* curve, ExceptionState& exceptionS
DOMFloat32Array* WaveShaperNode::curve()
{
- return getWaveShaperProcessor()->curve();
+ Vector<float>* curve = getWaveShaperProcessor()->curve();
+ if (!curve)
+ return nullptr;
+
+ unsigned size = curve->size();
+ RefPtr<WTF::Float32Array> newCurve = WTF::Float32Array::create(size);
+
+ memcpy(newCurve->data(), curve->data(), sizeof(float) * size);
+
+ return DOMFloat32Array::create(newCurve.release());
}
void WaveShaperNode::setOversample(const String& type)

Powered by Google App Engine
This is Rietveld 408576698