third_party/WebKit/Source/modules/webaudio/WaveShaperDSPKernel.cpp - Issue 2223613002: WaveShaperNode should copy its curve.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/WaveShaperDSPKernel.cpp

Issue 2223613002: WaveShaperNode should copy its curve. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address review comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webaudio/WaveShaperDSPKernel.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/WaveShaperDSPKernel.cpp b/third_party/WebKit/Source/modules/webaudio/WaveShaperDSPKernel.cpp

index f841b05a011302dc632fab2b9612afe28989d204..4942b28f677b7904b6f4d4d1f5a712fd29f305f5 100644

--- a/third_party/WebKit/Source/modules/webaudio/WaveShaperDSPKernel.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/WaveShaperDSPKernel.cpp

@@ -74,7 +74,7 @@ void WaveShaperDSPKernel::processCurve(const float* source, float* destination,

ASSERT(destination);

ASSERT(getWaveShaperProcessor());

- DOMFloat32Array* curve = getWaveShaperProcessor()->curve();

+ Vector<float>* curve = getWaveShaperProcessor()->curve();

if (!curve) {

// Act as "straight wire" pass-through if no curve is set.

memcpy(destination, source, sizeof(float) * framesToProcess);

@@ -82,7 +82,7 @@ void WaveShaperDSPKernel::processCurve(const float* source, float* destination,

}

float* curveData = curve->data();

- int curveLength = curve->length();

+ int curveLength = curve->size();

ASSERT(curveData);