Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2223353004: findit: prepare for running under remote_run (Closed)

Created:
4 years, 4 months ago by Paweł Hajdan Jr.
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

findit: prepare for running under remote_run - use path_config=kitchen in tests It's not a new type of change, and is part of wider effort to convert needed recipes and modules. Please see below CLs for older examples: https://codereview.chromium.org/2170863002 https://codereview.chromium.org/2171733002 https://codereview.chromium.org/2226683002 https://codereview.chromium.org/2228473002 BUG=584079, 593999 Committed: https://chromium.googlesource.com/chromium/tools/build/+/0232a12f269f590f84ab5a11b4d56e5a221eb574

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3567 lines, -1105 lines) Patch
M scripts/slave/recipes/findit/chromium/compile.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/compile.expected/check_suspected_revision_before_bisect.json View 28 chunks +108 lines, -33 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/compile.expected/compile_affected_targets_only.json View 19 chunks +68 lines, -19 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/compile.expected/compile_default_targets.json View 16 chunks +65 lines, -16 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/compile.expected/compile_failed.json View 16 chunks +65 lines, -16 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/compile.expected/compile_none_existing_targets.json View 16 chunks +63 lines, -16 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/compile.expected/compile_skipped.json View 17 chunks +62 lines, -15 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/compile.expected/compile_specified_targets.json View 18 chunks +69 lines, -20 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/compile.expected/compile_specified_targets_from_parameter.json View 18 chunks +69 lines, -20 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/compile.expected/compile_succeeded.json View 16 chunks +65 lines, -16 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/compile.expected/failed_compile_upon_infra_failure_goma_build_error.json View 18 chunks +69 lines, -20 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/compile.expected/failed_compile_upon_infra_failure_goma_ping_failure.json View 18 chunks +69 lines, -20 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/compile.expected/failed_compile_upon_infra_failure_goma_setup_failure.json View 18 chunks +69 lines, -20 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_as_first_revision_of_entire_range.json View 18 chunks +69 lines, -20 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_at_first_revision_of_a_sub_range.json View 28 chunks +108 lines, -33 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_in_middle_of_a_sub_range.json View 28 chunks +108 lines, -33 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_in_second_sub_range.json View 38 chunks +147 lines, -46 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/compile.expected/find_culprit_using_bisect.json View 36 chunks +141 lines, -42 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/test.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/test.expected/all_test_failed.json View 25 chunks +76 lines, -23 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/test.expected/all_test_passed.json View 25 chunks +76 lines, -23 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/test.expected/compile_skipped.json View 16 chunks +63 lines, -14 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/test.expected/findit_consecutive_culprits.json View 59 chunks +168 lines, -58 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_first_sub_range.json View 59 chunks +168 lines, -58 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_last_sub_range.json View 42 chunks +122 lines, -41 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/test.expected/findit_culprit_in_middle_sub_range.json View 76 chunks +214 lines, -75 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/test.expected/findit_steps_multiple_culprits.json View 81 chunks +220 lines, -78 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/test.expected/findit_tests_multiple_culprits.json View 93 chunks +260 lines, -92 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/test.expected/none_swarming_tests.json View 19 chunks +70 lines, -19 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/test.expected/nonexistent_test_step_skipped.json View 15 chunks +60 lines, -12 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/test.expected/only_one_test_passed.json View 25 chunks +76 lines, -23 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/test.expected/record_infra_failure.json View 18 chunks +67 lines, -18 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/test.expected/swarming_tests.json View 25 chunks +76 lines, -24 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/test.expected/test_without_targets_not_skipped.json View 19 chunks +66 lines, -17 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/test.expected/unaffected_test_skipped_by_analyze.json View 28 chunks +79 lines, -26 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/test.expected/use_analyze_set_to_False_for_non_linear_try_job.json View 42 chunks +122 lines, -41 lines 0 comments Download
M scripts/slave/recipes/findit/chromium/test.expected/use_build_parameter_for_tests.json View 59 chunks +168 lines, -58 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Paweł Hajdan Jr.
4 years, 4 months ago (2016-08-09 10:19:54 UTC) #2
emso
lgtm Thanks for the longer description.
4 years, 4 months ago (2016-08-09 10:35:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2223353004/1
4 years, 4 months ago (2016-08-09 10:39:31 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 10:43:52 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/0232a12f269f590f84ab...

Powered by Google App Engine
This is Rietveld 408576698