Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2171733002: blink_downstream: prepare for remote_run conversion (Closed)

Created:
4 years, 5 months ago by Paweł Hajdan Jr.
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixes #

Patch Set 3 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1587 lines, -324 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/api.py View 1 chunk +15 lines, -11 lines 0 comments Download
M scripts/slave/recipes/blink_downstream.py View 1 2 2 chunks +49 lines, -37 lines 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___ignition_fail.json View 1 16 chunks +108 lines, -20 lines 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64___ignition_pass.json View 1 12 chunks +102 lines, -16 lines 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__fail.json View 1 20 chunks +117 lines, -25 lines 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64__dbg__pass.json View 1 12 chunks +101 lines, -15 lines 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_fail.json View 1 20 chunks +117 lines, -25 lines 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Linux_64_pass.json View 1 12 chunks +101 lines, -15 lines 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_fail.json View 1 22 chunks +121 lines, -27 lines 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Mac_pass.json View 1 13 chunks +103 lines, -16 lines 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_fail.json View 1 18 chunks +115 lines, -23 lines 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/full_client_v8_fyi_V8_Blink_Win_pass.json View 1 10 chunks +100 lines, -14 lines 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/minimal_pass_continues.json View 1 20 chunks +117 lines, -25 lines 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/too_many_failures_for_retcode.json View 1 20 chunks +117 lines, -25 lines 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/webkit_tests_interrupted.json View 1 13 chunks +102 lines, -15 lines 0 comments Download
M scripts/slave/recipes/blink_downstream.expected/webkit_tests_unexpected_error.json View 1 13 chunks +102 lines, -15 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Paweł Hajdan Jr.
4 years, 5 months ago (2016-07-21 11:36:47 UTC) #2
Sergiy Byelozyorov
https://codereview.chromium.org/2171733002/diff/1/scripts/slave/recipes/blink_downstream.py File scripts/slave/recipes/blink_downstream.py (right): https://codereview.chromium.org/2171733002/diff/1/scripts/slave/recipes/blink_downstream.py#newcode139 scripts/slave/recipes/blink_downstream.py:139: with api.step.context(context): please explain in description why this context ...
4 years, 5 months ago (2016-07-21 12:00:24 UTC) #7
Paweł Hajdan Jr.
PTAL https://codereview.chromium.org/2171733002/diff/1/scripts/slave/recipes/blink_downstream.py File scripts/slave/recipes/blink_downstream.py (right): https://codereview.chromium.org/2171733002/diff/1/scripts/slave/recipes/blink_downstream.py#newcode139 scripts/slave/recipes/blink_downstream.py:139: with api.step.context(context): On 2016/07/21 at 12:00:24, Sergiy Byelozyorov ...
4 years, 5 months ago (2016-07-21 13:53:05 UTC) #8
tandrii(chromium)
lgtm
4 years, 5 months ago (2016-07-21 13:59:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2171733002/40001
4 years, 5 months ago (2016-07-21 14:00:27 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/tools/build/+/4782f9d39ee999116ffc6caacc793ef1cf1428ab
4 years, 5 months ago (2016-07-21 14:04:08 UTC) #13
Sergiy Byelozyorov
4 years, 5 months ago (2016-07-21 22:17:59 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698