Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1744)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2228473002: bisection: prepare for running under remote_run (Closed)

Created:
4 years, 4 months ago by Paweł Hajdan Jr.
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

bisection: prepare for running under remote_run - use path_config=kitchen in tests - use builder cache dir when available - use ensure_goma to get goma client - use api.path['cache'] instead of api.path['slave_build'] It's not a new type of change, and is part of wider effort to convert needed recipes and modules. Please see below CLs for older examples: https://codereview.chromium.org/2170863002 https://codereview.chromium.org/2171733002 https://codereview.chromium.org/2226683002 BUG=584079, 593999, 585401 Committed: https://chromium.googlesource.com/chromium/tools/build/+/1339fef58a9594620a9914a2aef0cf3146ad14b3

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12805 lines, -7046 lines) Patch
M scripts/slave/recipe_modules/auto_bisect/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/api.py View 4 chunks +13 lines, -6 lines 2 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/android_arm64_bisector.json View 2 chunks +57 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/android_bisector.json View 2 chunks +57 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/basic.json View 2 chunks +57 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/basic_bisect_script.json View 2 chunks +57 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/mac_bisector.json View 2 chunks +57 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/reversed_basic.json View 2 chunks +57 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/windows_bisector.json View 2 chunks +57 lines, -3 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/windows_x64_bisector.json View 2 chunks +57 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.py View 15 chunks +15 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_fyi_perf_bisect.json View 20 chunks +96 lines, -50 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus5X_perf_bisect.json View 20 chunks +96 lines, -50 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus5_perf_bisect.json View 20 chunks +96 lines, -50 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus6_perf_bisect.json View 20 chunks +96 lines, -50 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus7_perf_bisect.json View 20 chunks +96 lines, -50 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_nexus9_perf_bisect.json View 20 chunks +96 lines, -50 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_one_perf_bisect.json View 20 chunks +96 lines, -50 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_s5_perf_bisect.json View 20 chunks +96 lines, -50 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_s5_perf_cq.json View 20 chunks +96 lines, -50 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_android_webview_arm64_aosp_perf_bisect.json View 20 chunks +96 lines, -50 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_fyi_perf_bisect.json View 34 chunks +127 lines, -81 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus5X_perf_bisect.json View 34 chunks +127 lines, -81 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus5_perf_bisect.json View 34 chunks +127 lines, -81 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus6_perf_bisect.json View 34 chunks +127 lines, -81 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus7_perf_bisect.json View 34 chunks +127 lines, -81 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_nexus9_perf_bisect.json View 34 chunks +127 lines, -81 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_one_perf_bisect.json View 34 chunks +127 lines, -81 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_s5_perf_bisect.json View 34 chunks +127 lines, -81 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_s5_perf_cq.json View 34 chunks +127 lines, -81 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_android_webview_arm64_aosp_perf_bisect.json View 34 chunks +127 lines, -81 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_fyi_perf_bisect.json View 34 chunks +127 lines, -81 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5X_perf_bisect.json View 34 chunks +127 lines, -81 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus5_perf_bisect.json View 34 chunks +127 lines, -81 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus6_perf_bisect.json View 34 chunks +127 lines, -81 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus7_perf_bisect.json View 34 chunks +127 lines, -81 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_nexus9_perf_bisect.json View 34 chunks +127 lines, -81 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_one_perf_bisect.json View 34 chunks +127 lines, -81 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_s5_perf_bisect.json View 34 chunks +127 lines, -81 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_s5_perf_cq.json View 34 chunks +127 lines, -81 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_metric_android_webview_arm64_aosp_perf_bisect.json View 34 chunks +127 lines, -81 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_fyi_perf_bisect.json View 36 chunks +128 lines, -82 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus5X_perf_bisect.json View 36 chunks +128 lines, -82 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus5_perf_bisect.json View 36 chunks +128 lines, -82 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus6_perf_bisect.json View 36 chunks +128 lines, -82 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus7_perf_bisect.json View 36 chunks +128 lines, -82 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_nexus9_perf_bisect.json View 36 chunks +128 lines, -82 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_one_perf_bisect.json View 36 chunks +128 lines, -82 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_s5_perf_bisect.json View 36 chunks +128 lines, -82 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_s5_perf_cq.json View 36 chunks +128 lines, -82 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_perf_tryjob_with_revisions_android_webview_arm64_aosp_perf_bisect.json View 36 chunks +128 lines, -82 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_fyi_perf_bisect.json View 29 chunks +109 lines, -63 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus5X_perf_bisect.json View 29 chunks +109 lines, -63 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus5_perf_bisect.json View 29 chunks +109 lines, -63 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus6_perf_bisect.json View 29 chunks +109 lines, -63 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus7_perf_bisect.json View 29 chunks +109 lines, -63 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_nexus9_perf_bisect.json View 29 chunks +109 lines, -63 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_one_perf_bisect.json View 29 chunks +109 lines, -63 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_s5_perf_bisect.json View 29 chunks +109 lines, -63 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_s5_perf_cq.json View 29 chunks +109 lines, -63 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/basic_recipe_android_webview_arm64_aosp_perf_bisect.json View 30 chunks +115 lines, -69 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/local_basic_recipe_basic_device.json View 65 chunks +205 lines, -111 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/local_basic_recipe_disconnected_device.json View 112 chunks +321 lines, -179 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/local_basic_recipe_failed_device.json View 66 chunks +209 lines, -115 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/local_basic_recipe_no_device.json View 19 chunks +93 lines, -47 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_fyi_perf_bisect.json View 24 chunks +103 lines, -57 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus5X_perf_bisect.json View 24 chunks +103 lines, -57 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus5_perf_bisect.json View 24 chunks +103 lines, -57 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus6_perf_bisect.json View 24 chunks +103 lines, -57 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus7_perf_bisect.json View 24 chunks +103 lines, -57 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_nexus9_perf_bisect.json View 24 chunks +103 lines, -57 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_one_perf_bisect.json View 24 chunks +103 lines, -57 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_s5_perf_bisect.json View 24 chunks +103 lines, -57 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_s5_perf_cq.json View 24 chunks +103 lines, -57 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_benchmark_to_run_android_webview_arm64_aosp_perf_bisect.json View 24 chunks +103 lines, -57 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_fyi_perf_bisect.json View 18 chunks +89 lines, -43 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_nexus5X_perf_bisect.json View 18 chunks +89 lines, -43 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_nexus5_perf_bisect.json View 18 chunks +89 lines, -43 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_nexus6_perf_bisect.json View 18 chunks +89 lines, -43 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_nexus7_perf_bisect.json View 18 chunks +89 lines, -43 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_nexus9_perf_bisect.json View 18 chunks +89 lines, -43 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_one_perf_bisect.json View 18 chunks +89 lines, -43 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_s5_perf_bisect.json View 18 chunks +89 lines, -43 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_s5_perf_cq.json View 18 chunks +89 lines, -43 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_no_changes_android_webview_arm64_aosp_perf_bisect.json View 18 chunks +89 lines, -43 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_fyi_perf_bisect.json View 27 chunks +109 lines, -63 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus5X_perf_bisect.json View 27 chunks +109 lines, -63 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus5_perf_bisect.json View 27 chunks +109 lines, -63 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus6_perf_bisect.json View 27 chunks +109 lines, -63 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus7_perf_bisect.json View 27 chunks +109 lines, -63 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_nexus9_perf_bisect.json View 27 chunks +109 lines, -63 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_one_perf_bisect.json View 27 chunks +109 lines, -63 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_s5_perf_bisect.json View 27 chunks +109 lines, -63 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_s5_perf_cq.json View 27 chunks +109 lines, -63 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_cq_run_benchmark_android_webview_arm64_aosp_perf_bisect.json View 27 chunks +109 lines, -63 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_fyi_perf_bisect.json View 19 chunks +90 lines, -44 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_nexus5X_perf_bisect.json View 19 chunks +90 lines, -44 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_nexus5_perf_bisect.json View 19 chunks +90 lines, -44 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_nexus6_perf_bisect.json View 19 chunks +90 lines, -44 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_nexus7_perf_bisect.json View 19 chunks +90 lines, -44 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_nexus9_perf_bisect.json View 19 chunks +90 lines, -44 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_one_perf_bisect.json View 19 chunks +90 lines, -44 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_s5_perf_bisect.json View 19 chunks +90 lines, -44 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_s5_perf_cq.json View 19 chunks +90 lines, -44 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_config_error_android_webview_arm64_aosp_perf_bisect.json View 19 chunks +90 lines, -44 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_fyi_perf_bisect.json View 34 chunks +127 lines, -81 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus5X_perf_bisect.json View 34 chunks +127 lines, -81 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus5_perf_bisect.json View 34 chunks +127 lines, -81 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus6_perf_bisect.json View 34 chunks +127 lines, -81 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus7_perf_bisect.json View 34 chunks +127 lines, -81 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_nexus9_perf_bisect.json View 34 chunks +127 lines, -81 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_one_perf_bisect.json View 34 chunks +127 lines, -81 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_s5_perf_bisect.json View 34 chunks +127 lines, -81 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_s5_perf_cq.json View 34 chunks +127 lines, -81 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect.expected/perf_tryjob_failed_test_android_webview_arm64_aosp_perf_bisect.json View 34 chunks +127 lines, -81 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.py View 11 chunks +12 lines, -1 line 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic.json View 6 chunks +87 lines, -10 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_linux_bisect_tester_recipe.json View 12 chunks +35 lines, -8 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_linux_bisect_tester_recipe_ret_code.json View 12 chunks +35 lines, -8 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob.json View 13 chunks +38 lines, -14 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_metric.json View 13 chunks +38 lines, -14 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/basic_perf_tryjob_with_revisions.json View 15 chunks +40 lines, -17 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/perf_cq_no_benchmark_to_run.json View 7 chunks +28 lines, -5 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/perf_cq_no_changes.json View 4 chunks +25 lines, -2 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/perf_cq_run_benchmark.json View 10 chunks +34 lines, -11 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/perf_tryjob_config_error.json View 5 chunks +26 lines, -3 lines 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect.expected/perf_tryjob_failed_test.json View 13 chunks +38 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Paweł Hajdan Jr.
4 years, 4 months ago (2016-08-08 12:26:45 UTC) #2
tandrii(chromium)
LGTM % comment https://codereview.chromium.org/2228473002/diff/1/scripts/slave/recipe_modules/auto_bisect/api.py File scripts/slave/recipe_modules/auto_bisect/api.py (left): https://codereview.chromium.org/2228473002/diff/1/scripts/slave/recipe_modules/auto_bisect/api.py#oldcode180 scripts/slave/recipe_modules/auto_bisect/api.py:180: # TODO(phajdan.jr): update for swarming, http://crbug.com/585401 ...
4 years, 4 months ago (2016-08-08 12:58:12 UTC) #3
Paweł Hajdan Jr.
https://codereview.chromium.org/2228473002/diff/1/scripts/slave/recipe_modules/auto_bisect/api.py File scripts/slave/recipe_modules/auto_bisect/api.py (left): https://codereview.chromium.org/2228473002/diff/1/scripts/slave/recipe_modules/auto_bisect/api.py#oldcode180 scripts/slave/recipe_modules/auto_bisect/api.py:180: # TODO(phajdan.jr): update for swarming, http://crbug.com/585401 . On 2016/08/08 ...
4 years, 4 months ago (2016-08-08 12:59:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2228473002/1
4 years, 4 months ago (2016-08-08 12:59:27 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 13:04:53 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/1339fef58a9594620a99...

Powered by Google App Engine
This is Rietveld 408576698