Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2226683002: ios: prepare for running under remote_run (Closed)

Created:
4 years, 4 months ago by Paweł Hajdan Jr.
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

ios: prepare for running under remote_run - use path_config=kitchen in tests - use builder cache dir when available - rely on bot_update.ensure_checkout to set api.path['checkout'] It's not a new type of change, and is part of wider effort to convert needed recipes and modules. Please see below CLs for older examples: https://codereview.chromium.org/2170863002 https://codereview.chromium.org/2171733002 BUG=584079, 593999 Committed: https://chromium.googlesource.com/chromium/tools/build/+/70e3a56c9724b09e68aa6fe435e8db1c0defed15

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+491 lines, -80 lines) Patch
M scripts/slave/recipe_modules/ios/api.py View 1 chunk +6 lines, -3 lines 0 comments Download
M scripts/slave/recipes/ios/try.py View 9 chunks +9 lines, -0 lines 0 comments Download
M scripts/slave/recipes/ios/try.expected/basic.json View 6 chunks +27 lines, -4 lines 0 comments Download
M scripts/slave/recipes/ios/try.expected/gn.json View 7 chunks +30 lines, -7 lines 0 comments Download
M scripts/slave/recipes/ios/try.expected/gyp_goma.json View 7 chunks +30 lines, -7 lines 0 comments Download
M scripts/slave/recipes/ios/try.expected/icu_patch.json View 6 chunks +27 lines, -4 lines 0 comments Download
M scripts/slave/recipes/ios/try.expected/parent.json View 6 chunks +28 lines, -5 lines 0 comments Download
M scripts/slave/recipes/ios/try.expected/swarming.json View 6 chunks +28 lines, -5 lines 0 comments Download
M scripts/slave/recipes/ios/try.expected/swarming_tests_skipped.json View 6 chunks +27 lines, -4 lines 0 comments Download
M scripts/slave/recipes/ios/try.expected/without_patch_failure.json View 10 chunks +54 lines, -8 lines 0 comments Download
M scripts/slave/recipes/ios/try.expected/without_patch_success.json View 10 chunks +54 lines, -8 lines 0 comments Download
M scripts/slave/recipes/ios/unified_builder_tester.py View 6 chunks +6 lines, -0 lines 0 comments Download
M scripts/slave/recipes/ios/unified_builder_tester.expected/basic.json View 5 chunks +27 lines, -4 lines 0 comments Download
M scripts/slave/recipes/ios/unified_builder_tester.expected/goma.json View 7 chunks +30 lines, -5 lines 0 comments Download
M scripts/slave/recipes/ios/unified_builder_tester.expected/infrastructure_failure.json View 5 chunks +27 lines, -4 lines 0 comments Download
M scripts/slave/recipes/ios/unified_builder_tester.expected/multiple_failures.json View 5 chunks +27 lines, -4 lines 0 comments Download
M scripts/slave/recipes/ios/unified_builder_tester.expected/no_tests.json View 5 chunks +27 lines, -4 lines 0 comments Download
M scripts/slave/recipes/ios/unified_builder_tester.expected/test_failure.json View 5 chunks +27 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Paweł Hajdan Jr.
4 years, 4 months ago (2016-08-08 11:24:42 UTC) #2
tandrii(chromium)
+smut FYI LGTM
4 years, 4 months ago (2016-08-08 12:12:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2226683002/1
4 years, 4 months ago (2016-08-08 12:15:19 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 12:22:01 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/70e3a56c9724b09e68aa...

Powered by Google App Engine
This is Rietveld 408576698