Plumb ScheduleOverlayPlane into the GPU process.

Plumb ScheduleOverlayPlane into the GPU process.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262715

[alexst (slow to review), 2014-04-02 15:37:22]

Please have a look. I based this on PartialSwapBuffers/PostSubBufferCHROMIUM

[piman, 2014-04-02 20:09:38]

https://codereview.chromium.org/222333002/diff/1/gpu/command_buffer/build_gle...
File gpu/command_buffer/build_gles2_cmd_buffer.py (right):

https://codereview.chromium.org/222333002/diff/1/gpu/command_buffer/build_gle...
gpu/command_buffer/build_gles2_cmd_buffer.py:2542: 'impl_func': False,
I believe if you set it to true, it will autogen the GLES2Implementation
function.

https://codereview.chromium.org/222333002/diff/1/gpu/command_buffer/cmd_buffe...
File gpu/command_buffer/cmd_buffer_functions.txt (right):

https://codereview.chromium.org/222333002/diff/1/gpu/command_buffer/cmd_buffe...
gpu/command_buffer/cmd_buffer_functions.txt:223: GL_APICALL void        
GL_APIENTRY glScheduleOverlayPlaneCHROMIUM (GLint plane_z_order, GLenum
plane_transform, GLuint overlay_texture_id, GLint bounds_x, GLint bounds_y,
GLint bounds_width, GLint bounds_height, GLfloat uv_x, GLfloat uv_y, GLfloat
uv_width, GLfloat uv_height);
nit: can you add an extension specification for this? We try to add some for all
CHROMIUM extension, in gpu/GLES2/extensions/CHROMIUM/, see examples there. It's
a good place to document the behavior, in particular the interaction with
glSwapBuffers/glPostSubBufferCHROMIUM

https://codereview.chromium.org/222333002/diff/1/gpu/command_buffer/service/g...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/222333002/diff/1/gpu/command_buffer/service/g...
gpu/command_buffer/service/gles2_cmd_decoder.cc:7532: NOTREACHED() << "Overlay
supported isn't finished.";
nit: NOTIMPLEMENTED. It can be reached, with a buggy or malicious client.

https://codereview.chromium.org/222333002/diff/1/gpu/command_buffer/service/g...
gpu/command_buffer/service/gles2_cmd_decoder.cc:7533: return
error::kGenericError;
Rather than generating a command buffer error, which will lose the context, can
you raise GL_INVALID_OPERATION? (use LOCAL_SET_GL_ERROR).

[alexst (slow to review), 2014-04-08 19:46:26]

PTAL, sorry about the turnaround time, got distracted by something else.

https://codereview.chromium.org/222333002/diff/20001/gpu/GLES2/gl2extchromium.h
File gpu/GLES2/gl2extchromium.h (right):

https://codereview.chromium.org/222333002/diff/20001/gpu/GLES2/gl2extchromium...
gpu/GLES2/gl2extchromium.h:640: #ifndef GL_CHROMIUM_schedule_overlay_plane
I think this is another place that had to be added for consistency and to have a
non-ui/gfx specific enum flowing through the command buffer.

[piman, 2014-04-08 21:30:54]

LGTM+couple of nits.

https://codereview.chromium.org/222333002/diff/20001/gpu/GLES2/extensions/CHR...
File gpu/GLES2/extensions/CHROMIUM/CHROMIUM_schedule_overlay_plane.txt (right):

https://codereview.chromium.org/222333002/diff/20001/gpu/GLES2/extensions/CHR...
gpu/GLES2/extensions/CHROMIUM/CHROMIUM_schedule_overlay_plane.txt:26: This
extension could be used in cunjuntion with OES_EGL_image_external
nit: cunjunction->conjunction

https://codereview.chromium.org/222333002/diff/20001/gpu/GLES2/gl2extchromium.h
File gpu/GLES2/gl2extchromium.h (right):

https://codereview.chromium.org/222333002/diff/20001/gpu/GLES2/gl2extchromium...
gpu/GLES2/gl2extchromium.h:640: #ifndef GL_CHROMIUM_schedule_overlay_plane
On 2014/04/08 19:46:27, alexst wrote:
> I think this is another place that had to be added for consistency and to have
a
> non-ui/gfx specific enum flowing through the command buffer.

Yes, ok.

https://codereview.chromium.org/222333002/diff/20001/gpu/command_buffer/clien...
File gpu/command_buffer/client/gles2_implementation.cc (right):

https://codereview.chromium.org/222333002/diff/20001/gpu/command_buffer/clien...
gpu/command_buffer/client/gles2_implementation.cc:2842: case
gfx::OVERLAY_TRANSFORM_INVALID:
nit: case should be indented to. (git cl format is your friend).

[alexst (slow to review), 2014-04-09 14:19:21]

https://codereview.chromium.org/222333002/diff/20001/gpu/GLES2/extensions/CHR...
File gpu/GLES2/extensions/CHROMIUM/CHROMIUM_schedule_overlay_plane.txt (right):

https://codereview.chromium.org/222333002/diff/20001/gpu/GLES2/extensions/CHR...
gpu/GLES2/extensions/CHROMIUM/CHROMIUM_schedule_overlay_plane.txt:26: This
extension could be used in cunjuntion with OES_EGL_image_external
On 2014/04/08 21:30:54, piman wrote:
> nit: cunjunction->conjunction

Done.

https://codereview.chromium.org/222333002/diff/20001/gpu/command_buffer/clien...
File gpu/command_buffer/client/gles2_implementation.cc (right):

https://codereview.chromium.org/222333002/diff/20001/gpu/command_buffer/clien...
gpu/command_buffer/client/gles2_implementation.cc:2842: case
gfx::OVERLAY_TRANSFORM_INVALID:
On 2014/04/08 21:30:54, piman wrote:
> nit: case should be indented to. (git cl format is your friend).

Thanks for catching, I always run it, just forgot to do it on the last delta.

[alexst (slow to review), 2014-04-09 14:19:46]

The CQ bit was checked by alexst@chromium.org

[commit-bot: I haz the power, 2014-04-09 14:19:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexst@chromium.org/222333002/40001

[commit-bot: I haz the power, 2014-04-09 16:50:07]

Change committed as 262715