Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2222283002: Fix scriptCodeForHanFromSubtags() may return non-Han scripts (Closed)

Created:
4 years, 4 months ago by kojii
Modified:
4 years, 4 months ago
Reviewers:
drott
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix scriptCodeForHanFromSubtags() may return non-Han scripts This patch fixes a regression caused by the refactoring[1] that scriptCodeForHanFromSubtags() may return non-Han Ideographic scripts by sharing the script data with scriptCodeForHanFromSubtags(). Also clean up #include of LocaleToScriptMapping.h that are no longer used. [1] https://codereview.chromium.org/2192703002 BUG=635547 Committed: https://crrev.com/a03e3af96e1897c19e045842b8dd67b6eac3fa28 Cr-Commit-Position: refs/heads/master@{#410619}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M third_party/WebKit/Source/platform/LayoutLocale.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/platform/LayoutLocaleTest.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontDescription.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/android/FontCacheAndroid.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/LocaleToScriptMapping.h View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/text/LocaleToScriptMapping.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
kojii
PTAL. Sorry to miss this in the last CL.
4 years, 4 months ago (2016-08-09 06:19:53 UTC) #5
drott
LGTM
4 years, 4 months ago (2016-08-09 08:04:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222283002/1
4 years, 4 months ago (2016-08-09 08:43:12 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-09 08:47:29 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 08:50:21 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a03e3af96e1897c19e045842b8dd67b6eac3fa28
Cr-Commit-Position: refs/heads/master@{#410619}

Powered by Google App Engine
This is Rietveld 408576698