Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: third_party/WebKit/Source/platform/text/LocaleToScriptMapping.cpp

Issue 2222283002: Fix scriptCodeForHanFromSubtags() may return non-Han scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/text/LocaleToScriptMapping.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 494 matching lines...) Expand 10 before | Expand all | Expand 10 after
505 size_t len = (end == kNotFound ? locale.length() : end) - begin; 505 size_t len = (end == kNotFound ? locale.length() : end) - begin;
506 UScriptCode script; 506 UScriptCode script;
507 switch (len) { 507 switch (len) {
508 case 2: // region = 2ALPHA / 3DIGIT 508 case 2: // region = 2ALPHA / 3DIGIT
509 script = scriptCodeForHanFromRegion(locale.substring(begin, len)); 509 script = scriptCodeForHanFromRegion(locale.substring(begin, len));
510 if (script != USCRIPT_COMMON) 510 if (script != USCRIPT_COMMON)
511 return script; 511 return script;
512 break; 512 break;
513 case 4: // script = 4ALPHA 513 case 4: // script = 4ALPHA
514 script = scriptNameToCode(locale.substring(begin, len)); 514 script = scriptNameToCode(locale.substring(begin, len));
515 if (script != USCRIPT_INVALID_CODE) 515 if (isUnambiguousHanScript(script))
516 return script; 516 return script;
517 } 517 }
518 } 518 }
519 519
520 return USCRIPT_COMMON; 520 return USCRIPT_COMMON;
521 } 521 }
522 522
523 } // namespace blink 523 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/text/LocaleToScriptMapping.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698