Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Unified Diff: third_party/WebKit/Source/platform/LayoutLocale.cpp

Issue 2222283002: Fix scriptCodeForHanFromSubtags() may return non-Han scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/LayoutLocaleTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/LayoutLocale.cpp
diff --git a/third_party/WebKit/Source/platform/LayoutLocale.cpp b/third_party/WebKit/Source/platform/LayoutLocale.cpp
index 0a930c9f931e369448c1314a37a8357756a57c59..979f0559b69e0e51e19eef2d8737b1bd0275d401 100644
--- a/third_party/WebKit/Source/platform/LayoutLocale.cpp
+++ b/third_party/WebKit/Source/platform/LayoutLocale.cpp
@@ -54,16 +54,6 @@ const char* LayoutLocale::localeForSkFontMgr() const
return m_stringForSkFontMgr.data();
}
-static bool isUnambiguousHanScript(UScriptCode script)
-{
- // localeToScriptCodeForFontSelection() does not return these values.
- DCHECK(script != USCRIPT_HIRAGANA && script != USCRIPT_KATAKANA);
- return script == USCRIPT_KATAKANA_OR_HIRAGANA
- || script == USCRIPT_SIMPLIFIED_HAN
- || script == USCRIPT_TRADITIONAL_HAN
- || script == USCRIPT_HANGUL;
-}
-
void LayoutLocale::computeScriptForHan() const
{
if (isUnambiguousHanScript(m_script)) {
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/LayoutLocaleTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698