third_party/WebKit/Source/platform/text/LocaleToScriptMapping.cpp - Issue 2222283002: Fix scriptCodeForHanFromSubtags() may return non-Han scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/text/LocaleToScriptMapping.cpp

Issue 2222283002: Fix scriptCodeForHanFromSubtags() may return non-Han scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/text/LocaleToScriptMapping.cpp

diff --git a/third_party/WebKit/Source/platform/text/LocaleToScriptMapping.cpp b/third_party/WebKit/Source/platform/text/LocaleToScriptMapping.cpp

index d06e737f3075b2f553ac4740a832b1bb0e651e6d..ae2f92c6b5b5acad13fac354ce564f38c8b3bb7e 100644

--- a/third_party/WebKit/Source/platform/text/LocaleToScriptMapping.cpp

+++ b/third_party/WebKit/Source/platform/text/LocaleToScriptMapping.cpp

@@ -512,7 +512,7 @@ UScriptCode scriptCodeForHanFromSubtags(const String& locale, char delimiter)

break;

case 4: // script = 4ALPHA

script = scriptNameToCode(locale.substring(begin, len));

- if (script != USCRIPT_INVALID_CODE)

+ if (isUnambiguousHanScript(script))

return script;

}

« no previous file with comments | « third_party/WebKit/Source/platform/text/LocaleToScriptMapping.h ('k') | no next file » | no next file with comments »