Handle both plural and singular tab switcher content descriptions.

Handle both plural and singular tab switcher content descriptions.

This CL changes the tab switcher to use the correct grammatical category
of the number of tabs open.

BUG=635677
Committed: https://crrev.com/73c8f25a22e43a9cfab595782258d39b6dafac52
Cr-Commit-Position: refs/heads/master@{#412231}

[estevenson, 2016-08-09 15:27:11]

estevenson@chromium.org changed reviewers:
+ agrieve@chromium.org

[estevenson, 2016-08-09 15:27:12]

ptal

[agrieve, 2016-08-09 17:43:42]

lgtm afaict :)

https://codereview.chromium.org/2222013004/diff/20001/build/android/lint/supp...
File build/android/lint/suppressions.xml (right):

https://codereview.chromium.org/2222013004/diff/20001/build/android/lint/supp...
build/android/lint/suppressions.xml:84:
IDS_ACCESSIBILITY_TOOLBAR_BTN_TABSWITCHER_TOGGLE
nit: mention http://crbug.com/635677

[agrieve, 2016-08-09 17:44:21]

agrieve@chromium.org changed reviewers:
+ tedchoc@chromium.org

[agrieve, 2016-08-09 17:44:21]

tedchoc@chromium.org: Hoping you know how translations work.

[Ted C, 2016-08-15 21:51:55]

tedchoc@chromium.org changed reviewers:
+ ianwen@chromium.org

[Ted C, 2016-08-15 21:51:56]

Adding ianwen@, he reviewed the other usage of these plurals added by newt@ half
a year ago.  These look fine to me, but I'll defer to Ian for the final go
ahead.

[Ian Wen, 2016-08-15 22:51:12]

I checked the place where we used "N days ago" and "N minutes ago". It looks
like this patch follows https://codereview.chromium.org/1540663002 very closely.

lgtm

[Ted C, 2016-08-15 23:00:36]

rs lgtm (if needed for owners)

[estevenson, 2016-08-16 13:51:03]

The CQ bit was checked by estevenson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-16 13:51:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[estevenson, 2016-08-16 13:51:24]

https://codereview.chromium.org/2222013004/diff/20001/build/android/lint/supp...
File build/android/lint/suppressions.xml (right):

https://codereview.chromium.org/2222013004/diff/20001/build/android/lint/supp...
build/android/lint/suppressions.xml:84:
IDS_ACCESSIBILITY_TOOLBAR_BTN_TABSWITCHER_TOGGLE
On 2016/08/09 17:43:42, agrieve (OOO until aug 22) wrote:
> nit: mention http://crbug.com/635677

Done.

[commit-bot: I haz the power, 2016-08-16 14:24:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-16 14:24:56]

Dry run: This issue passed the CQ dry run.

[estevenson, 2016-08-16 14:25:25]

The CQ bit was checked by estevenson@chromium.org

[estevenson, 2016-08-16 14:25:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, ianwen@chromium.org, agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2222013004/#ps40001
(title: "rebase + add bug reference to comments")

[commit-bot: I haz the power, 2016-08-16 14:25:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 14:29:33]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-16 14:32:09]

Description was changed from

==========
Handle both plural and singular tab switcher content descriptions.

This CL changes the tab switcher to use the correct grammatical category
of the number of tabs open.

BUG=635677
==========

to

==========
Handle both plural and singular tab switcher content descriptions.

This CL changes the tab switcher to use the correct grammatical category
of the number of tabs open.

BUG=635677

Committed: https://crrev.com/73c8f25a22e43a9cfab595782258d39b6dafac52
Cr-Commit-Position: refs/heads/master@{#412231}
==========

[commit-bot: I haz the power, 2016-08-16 14:32:10]

Patchset 3 (id:??) landed as
https://crrev.com/73c8f25a22e43a9cfab595782258d39b6dafac52
Cr-Commit-Position: refs/heads/master@{#412231}