Prettier "last synced" times on the recent tabs page.

Prettier "last synced" times on the recent tabs page.

The recent tabs page shows when each synced device was last synced.
This improves that display in two ways:
 1. Better grammar: It now says "1 minute ago" instead of "1 minutes
    ago", etc. In some languages, this is an even bigger win than in
    English.
 2. Last synced times are now updated when the page is updated with new
    sync data

Committed: https://crrev.com/e2628cfcf3da6b3e8931980623c3790b98deca02
Cr-Commit-Position: refs/heads/master@{#366409}

[newt (away), 2015-12-18 21:40:52]

newt@chromium.org changed reviewers:
+ ianwen@chromium.org

[newt (away), 2015-12-18 21:40:52]

PTAL

[Ian Wen, 2015-12-21 13:03:45]

lgtm after fixing a tiny error.

BTW thanks for teaching me how to use plural strings!

https://chromiumcodereview.appspot.com/1540663002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsGroupView.java
(right):

https://chromiumcodereview.appspot.com/1540663002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsGroupView.java:178:
minutesElapsed);
Remove the third parameter?

https://chromiumcodereview.appspot.com/1540663002/diff/1/chrome/android/java/...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://chromiumcodereview.appspot.com/1540663002/diff/1/chrome/android/java/...
chrome/android/java/strings/android_chrome_strings.grd:1717: {MINUTES, plural,
=1 {# minute ago} other {# minutes ago}}
Do we have some documentation explaining chrome GRD file's plural grammar? These
are the first plural strings in android_chrome_strings.grd.

https://chromiumcodereview.appspot.com/1540663002/diff/1/chrome/android/java/...
chrome/android/java/strings/android_chrome_strings.grd:1725: <message
name="IDS_JUST_NOW" desc="A time label for an event that just now happened. For
example 'Last synced: just now'">
"...that happened just now."?

[newt (away), 2015-12-21 16:55:55]

https://chromiumcodereview.appspot.com/1540663002/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsGroupView.java
(right):

https://chromiumcodereview.appspot.com/1540663002/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsGroupView.java:178:
minutesElapsed);
On 2015/12/21 13:03:44, Ian Wen wrote:
> Remove the third parameter?

Oddly, the third parameter is required. The second parameter is used to
determine which quantity string to use; the third parameter is inserted into the
quantity string using String.format().

In many cases, the second and third parameter are the same. In some cases, you
might omit the third parameter. E.g. if the quantity strings are "You have a new
message / You have new messages", then you wouldn't need a third parameter,
since there's no "%d" to replace.

https://chromiumcodereview.appspot.com/1540663002/diff/1/chrome/android/java/...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://chromiumcodereview.appspot.com/1540663002/diff/1/chrome/android/java/...
chrome/android/java/strings/android_chrome_strings.grd:1717: {MINUTES, plural,
=1 {# minute ago} other {# minutes ago}}
On 2015/12/21 13:03:45, Ian Wen wrote:
> Do we have some documentation explaining chrome GRD file's plural grammar?
These
> are the first plural strings in android_chrome_strings.grd.

Not yet. Support for plurals and Android grds was added pretty recently. It's
basically a blend of plurals in non-Android grds with Android's quantity string
API. I'll update the Chromium l10n wiki:
https://www.chromium.org/developers/design-documents/ui-localization

https://chromiumcodereview.appspot.com/1540663002/diff/1/chrome/android/java/...
chrome/android/java/strings/android_chrome_strings.grd:1725: <message
name="IDS_JUST_NOW" desc="A time label for an event that just now happened. For
example 'Last synced: just now'">
On 2015/12/21 13:03:44, Ian Wen wrote:
> "...that happened just now."?

Done. That's probably a bit more readable.

[newt (away), 2015-12-21 16:55:59]

The CQ bit was checked by newt@chromium.org

[newt (away), 2015-12-21 16:55:59]

The patchset sent to the CQ was uploaded after l-g-t-m from ianwen@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1540663002/#ps20001
(title: "happened just now")

[commit-bot: I haz the power, 2015-12-21 16:56:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1540663002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1540663002/20001

[commit-bot: I haz the power, 2015-12-21 17:41:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-21 17:43:14]

Description was changed from

==========
Prettier "last synced" times on the recent tabs page.

The recent tabs page shows when each synced device was last synced.
This improves that display in two ways:
 1. Better grammar: It now says "1 minute ago" instead of "1 minutes
    ago", etc. In some languages, this is an even bigger win than in
    English.
 2. Last synced times are now updated when the page is updated with new
    sync data
==========

to

==========
Prettier "last synced" times on the recent tabs page.

The recent tabs page shows when each synced device was last synced.
This improves that display in two ways:
 1. Better grammar: It now says "1 minute ago" instead of "1 minutes
    ago", etc. In some languages, this is an even bigger win than in
    English.
 2. Last synced times are now updated when the page is updated with new
    sync data

Committed: https://crrev.com/e2628cfcf3da6b3e8931980623c3790b98deca02
Cr-Commit-Position: refs/heads/master@{#366409}
==========

[commit-bot: I haz the power, 2015-12-21 17:43:16]

Patchset 2 (id:??) landed as
https://crrev.com/e2628cfcf3da6b3e8931980623c3790b98deca02
Cr-Commit-Position: refs/heads/master@{#366409}