Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: chrome/android/java/res/layout-sw600dp/toolbar.xml

Issue 2222013004: Handle both plural and singular tab switcher content descriptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase + add bug reference to comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/lint/suppressions.xml ('k') | chrome/android/java/res/layout/toolbar.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <!-- The toolbar containing the URL bar, back button, and NTP button. 6 <!-- The toolbar containing the URL bar, back button, and NTP button.
7 --> 7 -->
8 8
9 <org.chromium.chrome.browser.toolbar.ToolbarTablet 9 <org.chromium.chrome.browser.toolbar.ToolbarTablet
10 xmlns:android="http://schemas.android.com/apk/res/android" 10 xmlns:android="http://schemas.android.com/apk/res/android"
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 android:layout_marginTop="5dp" 52 android:layout_marginTop="5dp"
53 android:layout_weight="1" 53 android:layout_weight="1"
54 android:layout_gravity="top|center" 54 android:layout_gravity="top|center"
55 android:background="@drawable/textbox" 55 android:background="@drawable/textbox"
56 android:paddingEnd="1dp" 56 android:paddingEnd="1dp"
57 android:paddingStart="2dp" /> 57 android:paddingStart="2dp" />
58 58
59 <ImageButton 59 <ImageButton
60 android:id="@+id/tab_switcher_button" 60 android:id="@+id/tab_switcher_button"
61 style="@style/ToolbarButton" 61 style="@style/ToolbarButton"
62 android:contentDescription="@string/accessibility_toolbar_btn_tabswi tcher_toggle" 62 android:contentDescription="@string/accessibility_toolbar_btn_tabswi tcher_toggle_default"
63 android:visibility="gone" /> 63 android:visibility="gone" />
64 64
65 <FrameLayout 65 <FrameLayout
66 android:layout_width="wrap_content" 66 android:layout_width="wrap_content"
67 android:layout_height="wrap_content" 67 android:layout_height="wrap_content"
68 android:id="@+id/menu_button_wrapper" > 68 android:id="@+id/menu_button_wrapper" >
69 69
70 <org.chromium.chrome.browser.widget.TintedImageButton 70 <org.chromium.chrome.browser.widget.TintedImageButton
71 android:id="@+id/menu_button" 71 android:id="@+id/menu_button"
72 style="@style/ToolbarMenuButtonTablet" 72 style="@style/ToolbarMenuButtonTablet"
73 android:src="@drawable/btn_menu" 73 android:src="@drawable/btn_menu"
74 android:contentDescription="@string/accessibility_toolbar_btn_me nu" /> 74 android:contentDescription="@string/accessibility_toolbar_btn_me nu" />
75 75
76 <ImageView 76 <ImageView
77 android:id="@+id/menu_badge" 77 android:id="@+id/menu_badge"
78 style="@style/ToolbarMenuButtonTablet" 78 style="@style/ToolbarMenuButtonTablet"
79 android:src="@drawable/badge_update_dark" 79 android:src="@drawable/badge_update_dark"
80 android:contentDescription="@null" 80 android:contentDescription="@null"
81 android:importantForAccessibility="no" 81 android:importantForAccessibility="no"
82 android:visibility="invisible" /> 82 android:visibility="invisible" />
83 83
84 </FrameLayout> 84 </FrameLayout>
85 </LinearLayout> 85 </LinearLayout>
86 </org.chromium.chrome.browser.toolbar.ToolbarTablet> 86 </org.chromium.chrome.browser.toolbar.ToolbarTablet>
OLDNEW
« no previous file with comments | « build/android/lint/suppressions.xml ('k') | chrome/android/java/res/layout/toolbar.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698