Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Side by Side Diff: build/android/lint/suppressions.xml

Issue 2222013004: Handle both plural and singular tab switcher content descriptions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase + add bug reference to comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/java/res/layout-sw600dp/toolbar.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <lint> 2 <lint>
3 <!-- 3 <!--
4 STOP! It looks like you want to suppress some lint errors: 4 STOP! It looks like you want to suppress some lint errors:
5 - Have you tried identifing the offending patch? 5 - Have you tried identifing the offending patch?
6 Ask the author for a fix and/or revert the patch. 6 Ask the author for a fix and/or revert the patch.
7 - It is preferred to add suppressions in the code instead of 7 - It is preferred to add suppressions in the code instead of
8 sweeping it under the rug here. See: 8 sweeping it under the rug here. See:
9 9
10 http://developer.android.com/tools/debugging/improving-w-lint.html 10 http://developer.android.com/tools/debugging/improving-w-lint.html
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 <issue id="InconsistentLayout" severity="ignore"/> 72 <issue id="InconsistentLayout" severity="ignore"/>
73 <issue id="InflateParams" severity="ignore"/> 73 <issue id="InflateParams" severity="ignore"/>
74 <issue id="LongLogTag" severity="ignore"/> 74 <issue id="LongLogTag" severity="ignore"/>
75 <issue id="MissingApplicationIcon" severity="ignore"/> 75 <issue id="MissingApplicationIcon" severity="ignore"/>
76 <issue id="MissingPermission" severity="ignore"/> 76 <issue id="MissingPermission" severity="ignore"/>
77 <issue id="MissingRegistered" severity="ignore"/> 77 <issue id="MissingRegistered" severity="ignore"/>
78 <issue id="MissingTranslation"> 78 <issue id="MissingTranslation">
79 <!-- http://crbug.com/450548 --> 79 <!-- http://crbug.com/450548 -->
80 <ignore regexp=".*restriction_values.xml.*" /> 80 <ignore regexp=".*restriction_values.xml.*" />
81 </issue> 81 </issue>
82 <!--
83 TODO(estevenson) remove this once translations are added for
84 IDS_ACCESSIBILITY_TOOLBAR_BTN_TABSWITCHER_TOGGLE (http://crbug.com/635677)
85 -->
86 <issue id="MissingQuantity">
87 <ignore regexp=".*android_chrome_strings.xml" />
88 </issue>
82 <issue id="MissingVersion"> 89 <issue id="MissingVersion">
83 <ignore path="AndroidManifest.xml"/> 90 <ignore path="AndroidManifest.xml"/>
84 </issue> 91 </issue>
85 <issue id="InlinedApi" severity="ignore"/> 92 <issue id="InlinedApi" severity="ignore"/>
86 <issue id="NewApi"> 93 <issue id="NewApi">
87 <ignore regexp="Attribute `paddingStart` referenced here can result in a cra sh on some specific devices older than API 17"/> 94 <ignore regexp="Attribute `paddingStart` referenced here can result in a cra sh on some specific devices older than API 17"/>
88 <ignore path="org/chromium/base/AnimationFrameTimeHistogram$Recorder.class"/ > 95 <ignore path="org/chromium/base/AnimationFrameTimeHistogram$Recorder.class"/ >
89 <ignore path="org/chromium/base/JavaHandlerThread.class"/> 96 <ignore path="org/chromium/base/JavaHandlerThread.class"/>
90 <ignore path="org/chromium/base/SysUtils.class"/> 97 <ignore path="org/chromium/base/SysUtils.class"/>
91 <ignore path="org/chromium/chrome/browser/TtsPlatformImpl.class"/> 98 <ignore path="org/chromium/chrome/browser/TtsPlatformImpl.class"/>
(...skipping 19 matching lines...) Expand all
111 <ignore path="android_webview/tools/automated_ui_tests/java/res/" /> 118 <ignore path="android_webview/tools/automated_ui_tests/java/res/" />
112 <!-- 119 <!--
113 This file isn't used if the target SDK version is less than 24. 120 This file isn't used if the target SDK version is less than 24.
114 TODO(estevenson) remove this and the conditional inclusion in 121 TODO(estevenson) remove this and the conditional inclusion in
115 AndroidManifest.xml after rolling to SDK 24. 122 AndroidManifest.xml after rolling to SDK 24.
116 --> 123 -->
117 <ignore path="chrome/android/java/res/xml/network_security_config.xml" /> 124 <ignore path="chrome/android/java/res/xml/network_security_config.xml" />
118 </issue> 125 </issue>
119 <issue id="SignatureOrSystemPermissions" severity="ignore"/> 126 <issue id="SignatureOrSystemPermissions" severity="ignore"/>
120 <issue id="UnusedAttribute" severity="ignore"/> 127 <issue id="UnusedAttribute" severity="ignore"/>
128 <!--
129 TODO(estevenson) remove this once translations are updated for
130 IDS_ACCESSIBILITY_TOOLBAR_BTN_TABSWITCHER_TOGGLE (http://crbug.com/635677)
131 -->
132 <issue id="UnusedQuantity">
133 <ignore regexp=".*android_chrome_strings.xml" />
134 </issue>
121 <issue id="ViewConstructor" severity="ignore"/> 135 <issue id="ViewConstructor" severity="ignore"/>
122 <issue id="WrongCall" severity="ignore"/> 136 <issue id="WrongCall" severity="ignore"/>
123 <issue id="UselessParent"> 137 <issue id="UselessParent">
124 <ignore path="chrome/android/java/res/layout/data_reduction_promo_screen.xml " /> 138 <ignore path="chrome/android/java/res/layout/data_reduction_promo_screen.xml " />
125 </issue> 139 </issue>
126 </lint> 140 </lint>
OLDNEW
« no previous file with comments | « no previous file | chrome/android/java/res/layout-sw600dp/toolbar.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698