[iOS] Simplify bundle creation by always calling codesign.py script.

[iOS] Simplify bundle creation by always calling codesign.py script.

Simplify the creation of bundle on iOS by always using the codesign.py
script to copy the bundle binary as only one configuration was using a
different code path: device build with no valid code signing identity.

Add a --disable-code-signature argument to codesign.py to disable the
creation of the code signature (though it is usually recommended to
just enable adhoc code signature by setting ios_code_signing_identity
to "-").

BUG=635302
Committed: https://crrev.com/feec21644aabe22f613b822489d71f305ebe2895
Cr-Commit-Position: refs/heads/master@{#410594}

[sdefresne, 2016-08-07 06:59:40]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-07 06:59:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-07 07:01:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-07 07:01:13]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sdefresne, 2016-08-07 07:32:00]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-07 07:32:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-08-07 07:32:30]

Patchset #1 (id:1) has been deleted

[sdefresne, 2016-08-07 07:33:07]

sdefresne@chromium.org changed reviewers:
+ dpranke@chromium.org

[sdefresne, 2016-08-07 07:33:07]

Please take a look.

[sdefresne, 2016-08-07 07:37:38]

Description was changed from

==========
[iOS] Simplify bundle creation by always calling codesign.py script.

Simplify the creation of bundle on iOS by always using the codesign.py
script to copy the bundle binary as only one configuration was using a
different code path: device build with no valid code signing identity.

Add a --disable-code-signature arguemnt to codesign.py to disable the
creation of the code signature (though it is usually recommended to
just enable adhoc code signature by setting ios_code_signing_identity
to "-").

BUG=None
==========

to

==========
[iOS] Simplify bundle creation by always calling codesign.py script.

Simplify the creation of bundle on iOS by always using the codesign.py
script to copy the bundle binary as only one configuration was using a
different code path: device build with no valid code signing identity.

Add a --disable-code-signature arguemnt to codesign.py to disable the
creation of the code signature (though it is usually recommended to
just enable adhoc code signature by setting ios_code_signing_identity
to "-").

BUG=635302
==========

[commit-bot: I haz the power, 2016-08-07 08:39:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-07 08:39:54]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-08-08 22:32:52]

Description was changed from

==========
[iOS] Simplify bundle creation by always calling codesign.py script.

Simplify the creation of bundle on iOS by always using the codesign.py
script to copy the bundle binary as only one configuration was using a
different code path: device build with no valid code signing identity.

Add a --disable-code-signature arguemnt to codesign.py to disable the
creation of the code signature (though it is usually recommended to
just enable adhoc code signature by setting ios_code_signing_identity
to "-").

BUG=635302
==========

to

==========
[iOS] Simplify bundle creation by always calling codesign.py script.

Simplify the creation of bundle on iOS by always using the codesign.py
script to copy the bundle binary as only one configuration was using a
different code path: device build with no valid code signing identity.

Add a --disable-code-signature argument to codesign.py to disable the
creation of the code signature (though it is usually recommended to
just enable adhoc code signature by setting ios_code_signing_identity
to "-").

BUG=635302
==========

[Dirk Pranke, 2016-08-08 22:34:03]

lgtm

[sdefresne, 2016-08-09 04:34:48]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2016-08-09 04:54:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 06:06:49]

Description was changed from

==========
[iOS] Simplify bundle creation by always calling codesign.py script.

Simplify the creation of bundle on iOS by always using the codesign.py
script to copy the bundle binary as only one configuration was using a
different code path: device build with no valid code signing identity.

Add a --disable-code-signature argument to codesign.py to disable the
creation of the code signature (though it is usually recommended to
just enable adhoc code signature by setting ios_code_signing_identity
to "-").

BUG=635302
==========

to

==========
[iOS] Simplify bundle creation by always calling codesign.py script.

Simplify the creation of bundle on iOS by always using the codesign.py
script to copy the bundle binary as only one configuration was using a
different code path: device build with no valid code signing identity.

Add a --disable-code-signature argument to codesign.py to disable the
creation of the code signature (though it is usually recommended to
just enable adhoc code signature by setting ios_code_signing_identity
to "-").

BUG=635302
==========

[commit-bot: I haz the power, 2016-08-09 06:06:50]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-08-09 06:09:13]

Description was changed from

==========
[iOS] Simplify bundle creation by always calling codesign.py script.

Simplify the creation of bundle on iOS by always using the codesign.py
script to copy the bundle binary as only one configuration was using a
different code path: device build with no valid code signing identity.

Add a --disable-code-signature argument to codesign.py to disable the
creation of the code signature (though it is usually recommended to
just enable adhoc code signature by setting ios_code_signing_identity
to "-").

BUG=635302
==========

to

==========
[iOS] Simplify bundle creation by always calling codesign.py script.

Simplify the creation of bundle on iOS by always using the codesign.py
script to copy the bundle binary as only one configuration was using a
different code path: device build with no valid code signing identity.

Add a --disable-code-signature argument to codesign.py to disable the
creation of the code signature (though it is usually recommended to
just enable adhoc code signature by setting ios_code_signing_identity
to "-").

BUG=635302

Committed: https://crrev.com/feec21644aabe22f613b822489d71f305ebe2895
Cr-Commit-Position: refs/heads/master@{#410594}
==========

[commit-bot: I haz the power, 2016-08-09 06:09:14]

Patchset 1 (id:??) landed as
https://crrev.com/feec21644aabe22f613b822489d71f305ebe2895
Cr-Commit-Position: refs/heads/master@{#410594}