Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: build/config/ios/codesign.py

Issue 2221773002: [iOS] Simplify bundle creation by always calling codesign.py script. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@{.}
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/ios/rules.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/ios/codesign.py
diff --git a/build/config/ios/codesign.py b/build/config/ios/codesign.py
index 4cc0820d6ed31cd6587fac57572f5356d562d235..5fb96da334d1d7138356973b6a4298854e5df75f 100644
--- a/build/config/ios/codesign.py
+++ b/build/config/ios/codesign.py
@@ -268,8 +268,12 @@ class CodeSignBundleAction(Action):
'--binary', '-b', required=True,
help='path to the iOS bundle binary')
parser.add_argument(
- '--framework', '-F', action='append', default=[], dest="frameworks",
+ '--framework', '-F', action='append', default=[], dest='frameworks',
help='install and resign system framework')
+ parser.add_argument(
+ '--disable-code-signature', action='store_false', dest='sign',
+ help='disable code signature')
+ parser.set_defaults(sign=True)
@staticmethod
def _Execute(args):
@@ -301,6 +305,9 @@ class CodeSignBundleAction(Action):
os.unlink(bundle.binary_path)
shutil.copy(args.binary, bundle.binary_path)
+ if not args.sign:
+ return
+
# Embeds entitlements into the code signature (if code signing identify has
# been provided).
codesign_extra_args = []
« no previous file with comments | « no previous file | build/config/ios/rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698