Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2222753003: [iOS] Always generate the final binaries using lipo. (Closed)

Created:
4 years, 4 months ago by sdefresne
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@always-code-sign
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Always generate the final binaries using lipo. To simplify the creation of binary bundles on iOS, always use lipo to create the final binary, even when not generating fat binaries (in that case the lipo invocation is just a simple copy unless dSYM generation or code stripping are enabled). BUG=635302 Committed: https://crrev.com/c7091801f98c82e3a1a0aa5c89feed19738c713c Cr-Commit-Position: refs/heads/master@{#410600}

Patch Set 1 #

Patch Set 2 : Fix toolchain declaration. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -269 lines) Patch
M build/config/ios/rules.gni View 1 16 chunks +192 lines, -252 lines 0 comments Download
M build/config/mac/BUILD.gn View 1 chunk +4 lines, -10 lines 0 comments Download
M build/toolchain/mac/BUILD.gn View 1 1 chunk +7 lines, -7 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 24 (19 generated)
sdefresne
Please take a look.
4 years, 4 months ago (2016-08-07 07:34:18 UTC) #8
Dirk Pranke
lgtm
4 years, 4 months ago (2016-08-08 22:37:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2222753003/40001
4 years, 4 months ago (2016-08-09 06:23:35 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 4 months ago (2016-08-09 07:06:11 UTC) #22
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 07:08:17 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c7091801f98c82e3a1a0aa5c89feed19738c713c
Cr-Commit-Position: refs/heads/master@{#410600}

Powered by Google App Engine
This is Rietveld 408576698