Refactor code signing script and template.

Refactor code signing script and template.

As code signing is enabled for simulator builds, refactor script and
template to eventually always code sign the bundles created on iOS
with either a adhoc signature (when no code signature identity is
available or for simulator builds) or a real code signature (when a
code signature identity is selected for device builds).

BUG=635302
Committed: https://crrev.com/f0d4ca9d29bb81e3477ddd76fea73721f63fa4a3
Cr-Commit-Position: refs/heads/master@{#410573}

[sdefresne, 2016-08-05 18:19:51]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 18:20:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-08-05 18:21:04]

sdefresne@chromium.org changed reviewers:
+ dpranke@chromium.org

[sdefresne, 2016-08-05 18:21:05]

Please take a look.

[commit-bot: I haz the power, 2016-08-05 19:18:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 19:18:33]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2016-08-07 07:31:00]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2016-08-07 07:31:07]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-08-07 07:31:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-08-07 07:31:16]

Patchset #1 (id:20001) has been deleted

[sdefresne, 2016-08-07 07:37:49]

Description was changed from

==========
Refactor code signing script and template.

As code signing is enabled for simulator builds, refactor script and
template to eventually always code sign the bundles created on iOS
with either a adhoc signature (when no code signature identity is
available or for simulator builds) or a real code signature (when a
code signature identity is selected for device builds).

BUG=None
==========

to

==========
Refactor code signing script and template.

As code signing is enabled for simulator builds, refactor script and
template to eventually always code sign the bundles created on iOS
with either a adhoc signature (when no code signature identity is
available or for simulator builds) or a real code signature (when a
code signature identity is selected for device builds).

BUG=635302
==========

[commit-bot: I haz the power, 2016-08-07 08:34:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-07 08:34:11]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-08-08 22:15:38]

lgtm

https://codereview.chromium.org/2224553002/diff/40001/build/config/ios/codesi...
File build/config/ios/codesign.py (right):

https://codereview.chromium.org/2224553002/diff/40001/build/config/ios/codesi...
build/config/ios/codesign.py:174: sys.exit(1)
nit: this is minor, but I'd write this as:

if required:
  sys.stderr.write(...)
  sys.exit(1)
return None

https://codereview.chromium.org/2224553002/diff/40001/build/config/ios/codesi...
build/config/ios/codesign.py:255: return 'perform code signature for a bundle'
this would more idiomatically be:

  name = 'code-sign-bundle'
  
  help = '...'

i.e., don't use getters.

[sdefresne, 2016-08-08 22:28:52]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2016-08-08 22:28:55]

https://codereview.chromium.org/2224553002/diff/40001/build/config/ios/codesi...
File build/config/ios/codesign.py (right):

https://codereview.chromium.org/2224553002/diff/40001/build/config/ios/codesi...
build/config/ios/codesign.py:174: sys.exit(1)
On 2016/08/08 22:15:36, Dirk Pranke wrote:
> nit: this is minor, but I'd write this as:
> 
> if required:
>   sys.stderr.write(...)
>   sys.exit(1)
> return None

Done.

https://codereview.chromium.org/2224553002/diff/40001/build/config/ios/codesi...
build/config/ios/codesign.py:255: return 'perform code signature for a bundle'
On 2016/08/08 22:15:36, Dirk Pranke wrote:
> this would more idiomatically be:
> 
>   name = 'code-sign-bundle'
>   
>   help = '...'
> 
> i.e., don't use getters.

Done.

[commit-bot: I haz the power, 2016-08-08 22:29:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 22:47:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 22:47:31]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[sdefresne, 2016-08-09 01:13:01]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-08-09 01:13:01]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2224553002/#ps60001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-08-09 01:13:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 01:28:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 01:28:15]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[sdefresne, 2016-08-09 04:11:05]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2016-08-09 04:11:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 04:24:27]

Description was changed from

==========
Refactor code signing script and template.

As code signing is enabled for simulator builds, refactor script and
template to eventually always code sign the bundles created on iOS
with either a adhoc signature (when no code signature identity is
available or for simulator builds) or a real code signature (when a
code signature identity is selected for device builds).

BUG=635302
==========

to

==========
Refactor code signing script and template.

As code signing is enabled for simulator builds, refactor script and
template to eventually always code sign the bundles created on iOS
with either a adhoc signature (when no code signature identity is
available or for simulator builds) or a real code signature (when a
code signature identity is selected for device builds).

BUG=635302
==========

[commit-bot: I haz the power, 2016-08-09 04:24:29]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-08-09 04:26:09]

Description was changed from

==========
Refactor code signing script and template.

As code signing is enabled for simulator builds, refactor script and
template to eventually always code sign the bundles created on iOS
with either a adhoc signature (when no code signature identity is
available or for simulator builds) or a real code signature (when a
code signature identity is selected for device builds).

BUG=635302
==========

to

==========
Refactor code signing script and template.

As code signing is enabled for simulator builds, refactor script and
template to eventually always code sign the bundles created on iOS
with either a adhoc signature (when no code signature identity is
available or for simulator builds) or a real code signature (when a
code signature identity is selected for device builds).

BUG=635302

Committed: https://crrev.com/f0d4ca9d29bb81e3477ddd76fea73721f63fa4a3
Cr-Commit-Position: refs/heads/master@{#410573}
==========

[commit-bot: I haz the power, 2016-08-09 04:26:10]

Patchset 2 (id:??) landed as
https://crrev.com/f0d4ca9d29bb81e3477ddd76fea73721f63fa4a3
Cr-Commit-Position: refs/heads/master@{#410573}